You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/23 08:59:38 UTC
[GitHub] [airflow] potiuk opened a new pull request #10491: Add a possibility to switch back to building images by secret
potiuk opened a new pull request #10491:
URL: https://github.com/apache/airflow/pull/10491
You can now define secret in your own fork:
GITHUB_REGISTRY_WAIT_FOR_IMAGE
If you set it to "false", it skips building images in separate
workflow_run - images will be built in the jobs run in the
CI Build run and they won't be pushed to the registry.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10491: Add a possibility to switch back to building images by secret
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10491:
URL: https://github.com/apache/airflow/pull/10491#issuecomment-679002269
I also explain that in #10380 where I keep the docs updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #10491: Add a possibility to switch back to building images by secret
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #10491:
URL: https://github.com/apache/airflow/pull/10491#issuecomment-679076621
Should we add some docs about it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #10491: Add a possibility to switch back to building images by secret
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #10491:
URL: https://github.com/apache/airflow/pull/10491#issuecomment-679132404
PR #10509 reopened
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #10491: Add a possibility to switch back to building images by secret
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #10491:
URL: https://github.com/apache/airflow/pull/10491#issuecomment-679075288
Both. :-D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj closed pull request #10491: Add a possibility to switch back to building images by secret
Posted by GitBox <gi...@apache.org>.
mik-laj closed pull request #10491:
URL: https://github.com/apache/airflow/pull/10491
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #10491: Add a possibility to switch back to building images by secret
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #10491:
URL: https://github.com/apache/airflow/pull/10491#issuecomment-679075288
Both. 🐈
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10491: Add a possibility to switch back to building images by secret
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10491:
URL: https://github.com/apache/airflow/pull/10491#issuecomment-679132404
PR #10509
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] feluelle commented on a change in pull request #10491: Add a possibility to switch back to building images by secret
Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #10491:
URL: https://github.com/apache/airflow/pull/10491#discussion_r475394600
##########
File path: .github/workflows/build-images-workflow-run.yml
##########
@@ -39,6 +39,7 @@ env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_REGISTRY_PULL_IMAGE_TAG: "latest"
GITHUB_REGISTRY_WAIT_FOR_IMAGE: "false"
+ BUILD_IMAGES: ${{ secrets.AIRFLOW_GITHUB_REGISTRY_WAIT_FOR_IMAGE != 'false' }}
Review comment:
```suggestion
BUILD_IMAGES: ${{ secrets.AIRFLOW_GITHUB_REGISTRY_WAIT_FOR_IMAGE }}
```
##########
File path: .github/workflows/ci.yml
##########
@@ -56,9 +56,10 @@ env:
#
# GITHUB_REGISTRY_WAIT_FOR_IMAGE: "false"
#
+ # You can also switch back to building images locally and disabling the "Build Images" workflow
+ # by defining AIRFLOW_GITHUB_REGISTRY_WAIT_FOR_IMAGE secret with value set to "false"
- GITHUB_REGISTRY_WAIT_FOR_IMAGE: "true"
-
+ GITHUB_REGISTRY_WAIT_FOR_IMAGE: ${{ secrets.AIRFLOW_GITHUB_REGISTRY_WAIT_FOR_IMAGE != 'false' }}
Review comment:
```suggestion
GITHUB_REGISTRY_WAIT_FOR_IMAGE: ${{ secrets.AIRFLOW_GITHUB_REGISTRY_WAIT_FOR_IMAGE }}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #10491: Add a possibility to switch back to building images by secret
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #10491:
URL: https://github.com/apache/airflow/pull/10491#discussion_r475441741
##########
File path: .github/workflows/ci.yml
##########
@@ -56,9 +56,10 @@ env:
#
# GITHUB_REGISTRY_WAIT_FOR_IMAGE: "false"
#
+ # You can also switch back to building images locally and disabling the "Build Images" workflow
+ # by defining AIRFLOW_GITHUB_REGISTRY_WAIT_FOR_IMAGE secret with value set to "false"
- GITHUB_REGISTRY_WAIT_FOR_IMAGE: "true"
-
+ GITHUB_REGISTRY_WAIT_FOR_IMAGE: ${{ secrets.AIRFLOW_GITHUB_REGISTRY_WAIT_FOR_IMAGE != 'false' }}
Review comment:
As explained below - I only want the secret to trigger the "BUILD_IMAGE=false" if it is defined and it has "false" value. So the condition is actually OK :)
##########
File path: .github/workflows/ci.yml
##########
@@ -56,9 +56,10 @@ env:
#
# GITHUB_REGISTRY_WAIT_FOR_IMAGE: "false"
#
+ # You can also switch back to building images locally and disabling the "Build Images" workflow
+ # by defining AIRFLOW_GITHUB_REGISTRY_WAIT_FOR_IMAGE secret with value set to "false"
- GITHUB_REGISTRY_WAIT_FOR_IMAGE: "true"
-
+ GITHUB_REGISTRY_WAIT_FOR_IMAGE: ${{ secrets.AIRFLOW_GITHUB_REGISTRY_WAIT_FOR_IMAGE != 'false' }}
Review comment:
I pushed back the original change
##########
File path: .github/workflows/build-images-workflow-run.yml
##########
@@ -39,6 +39,7 @@ env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_REGISTRY_PULL_IMAGE_TAG: "latest"
GITHUB_REGISTRY_WAIT_FOR_IMAGE: "false"
+ BUILD_IMAGES: ${{ secrets.AIRFLOW_GITHUB_REGISTRY_WAIT_FOR_IMAGE != 'false' }}
Review comment:
Same here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10491: Add a possibility to switch back to building images by secret
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10491:
URL: https://github.com/apache/airflow/pull/10491#issuecomment-678999054
Indeed @feluelle -> it should work this way :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10491: Add a possibility to switch back to building images by secret
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10491:
URL: https://github.com/apache/airflow/pull/10491#issuecomment-679130321
> Should we add some docs about it?
See the comment I made above:
> I also explain that in #10380 where I keep the docs updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10491: Add a possibility to switch back to building images by secret
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10491:
URL: https://github.com/apache/airflow/pull/10491#issuecomment-678999892
Well. not really @feluelle :(. The problem is when you have not defined secret - then I wanted to behave it as if it was "true" - now it 'is "empty" :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #10491: Add a possibility to switch back to building images by secret
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #10491:
URL: https://github.com/apache/airflow/pull/10491#issuecomment-679006391
I would like to do a review today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #10491: Add a possibility to switch back to building images by secret
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #10491:
URL: https://github.com/apache/airflow/pull/10491#issuecomment-679091888
@potiuk Can you create a new PR? I accidentally broke this one when I tested it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10491: Add a possibility to switch back to building images by secret
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10491:
URL: https://github.com/apache/airflow/pull/10491#issuecomment-679015961
@mik-laj of this PR or the Doc one ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org