[GitHub] spark pull request #15628: [SPARK-17471][ML] Add compressed method to ML mat...

[jkbradley <gi...@git.apache.org>]

Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15628#discussion_r116596231
  
    --- Diff: mllib-local/src/main/scala/org/apache/spark/ml/linalg/Matrices.scala ---
    @@ -148,7 +154,8 @@ sealed trait Matrix extends Serializable {
        *          and column indices respectively with the type `Int`, and the final parameter is the
        *          corresponding value in the matrix with type `Double`.
        */
    -  private[spark] def foreachActive(f: (Int, Int, Double) => Unit)
    +  @Since("2.2.0")
    +  def foreachActive(f: (Int, Int, Double) => Unit): Unit
    --- End diff --
    
    @sethah @dbtsai Hi all, just saw this during QA.  This method is not very Java-friendly.  I'm OK with adding it as long as we document the fact that it's not Java-friendly.  We could also consider adding a Java-friendly version, perhaps using https://spark.apache.org/docs/latest/api/java/org/apache/spark/api/java/function/Function2.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org