You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/09/14 23:38:29 UTC

[Impala-ASF-CR] IMPALA-11585: Build quickstart client with Ubuntu 20

Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18984


Change subject: IMPALA-11585: Build quickstart_client with Ubuntu 20
......................................................................

IMPALA-11585: Build quickstart_client with Ubuntu 20

Ubuntu 20.04 only provides the python3-pip package. Update building
quickstart_client to use python3-pip on Ubuntu 20.04.

Change-Id: Ife89b7db88dd58e96ba1b3e3972ca97204332dd4
---
M docker/CMakeLists.txt
M docker/publish_images_to_apache.sh
M docker/quickstart_client/Dockerfile
3 files changed, 7 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/18984/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18984
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife89b7db88dd58e96ba1b3e3972ca97204332dd4
Gerrit-Change-Number: 18984
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-11585: Build quickstart client with Ubuntu 20

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18984 )

Change subject: IMPALA-11585: Build quickstart_client with Ubuntu 20
......................................................................

IMPALA-11585: Build quickstart_client with Ubuntu 20

Ubuntu 20.04 only provides the python3-pip package. Update building
quickstart_client to use python3-pip on Ubuntu 20.04.

Change-Id: Ife89b7db88dd58e96ba1b3e3972ca97204332dd4
Reviewed-on: http://gerrit.cloudera.org:8080/18984
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docker/CMakeLists.txt
M docker/publish_images_to_apache.sh
M docker/quickstart_client/Dockerfile
3 files changed, 7 insertions(+), 4 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18984
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife89b7db88dd58e96ba1b3e3972ca97204332dd4
Gerrit-Change-Number: 18984
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-11585: Build quickstart client with Ubuntu 20

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18984 )

Change subject: IMPALA-11585: Build quickstart_client with Ubuntu 20
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11354/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18984
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife89b7db88dd58e96ba1b3e3972ca97204332dd4
Gerrit-Change-Number: 18984
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Sep 2022 23:59:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11585: Build quickstart client with Ubuntu 20

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18984 )

Change subject: IMPALA-11585: Build quickstart_client with Ubuntu 20
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18984
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife89b7db88dd58e96ba1b3e3972ca97204332dd4
Gerrit-Change-Number: 18984
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Sep 2022 23:10:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11585: Build quickstart client with Ubuntu 20

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18984 )

Change subject: IMPALA-11585: Build quickstart_client with Ubuntu 20
......................................................................


Patch Set 1:

What needs to happen next on this patch?


-- 
To view, visit http://gerrit.cloudera.org:8080/18984
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife89b7db88dd58e96ba1b3e3972ca97204332dd4
Gerrit-Change-Number: 18984
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Sep 2022 17:38:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11585: Build quickstart client with Ubuntu 20

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18984 )

Change subject: IMPALA-11585: Build quickstart_client with Ubuntu 20
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8618/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18984
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife89b7db88dd58e96ba1b3e3972ca97204332dd4
Gerrit-Change-Number: 18984
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Sep 2022 17:51:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11585: Build quickstart client with Ubuntu 20

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18984 )

Change subject: IMPALA-11585: Build quickstart_client with Ubuntu 20
......................................................................


Patch Set 1: Code-Review+2

This makes sense to me


-- 
To view, visit http://gerrit.cloudera.org:8080/18984
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife89b7db88dd58e96ba1b3e3972ca97204332dd4
Gerrit-Change-Number: 18984
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Sep 2022 18:15:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11585: Build quickstart client with Ubuntu 20

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18984 )

Change subject: IMPALA-11585: Build quickstart_client with Ubuntu 20
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18984
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife89b7db88dd58e96ba1b3e3972ca97204332dd4
Gerrit-Change-Number: 18984
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Sep 2022 17:51:28 +0000
Gerrit-HasComments: No