[GitHub] [hudi] xiarixiaoyao commented on a diff in pull request #7173: [HUDI-5189] Make HiveAvroSerializer compatible with hive3

["xiarixiaoyao (via GitHub)" <gi...@apache.org>]

xiarixiaoyao commented on code in PR #7173:
URL: https://github.com/apache/hudi/pull/7173#discussion_r1171189432


##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieHiveUtils.java:
##########
@@ -160,61 +158,38 @@ public static boolean isIncrementalUseDatabase(Configuration conf) {
 
   public static final String HIVE_TIMESTAMP_TYPE_CLASS = "org.apache.hadoop.hive.common.type.Timestamp";
   public static final String TIMESTAMP_WRITEABLE_V2_CLASS = "org.apache.hadoop.hive.serde2.io.TimestampWritableV2";
-  public static final boolean SUPPORT_TIMESTAMP_WRITEABLE_V2;
-  private static final Class TIMESTAMP_CLASS;
-  private static final Method SET_TIME_IN_MILLIS;
-  private static final Constructor TIMESTAMP_WRITEABLE_V2_CONSTRUCTOR;
+  public static boolean SUPPORT_TIMESTAMP_WRITEABLE_V2 = false;
+  private static Class TIMESTAMP_CLASS = null;
+  private static Method SET_TIME_IN_MILLIS = null;
+  private static Method TO_SQL_TIMESTAMP = null;
+  private static Constructor TIMESTAMP_WRITEABLE_V2_CONSTRUCTOR = null;
 
-  public static final String DATE_WRITEABLE_V2_CLASS = "org.apache.hadoop.hive.serde2.io.DateWritableV2";
-  public static final boolean SUPPORT_DATE_WRITEABLE_V2;
-  private static final Constructor DATE_WRITEABLE_V2_CONSTRUCTOR;
+  public static String DATE_WRITEABLE_V2_CLASS = "org.apache.hadoop.hive.serde2.io.DateWritableV2";

Review Comment:
   final ？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org