[jira] [Commented] (DRILL-4455) Depend on Apache Arrow for Vector and Memory

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173072#comment-15173072 ] 

ASF GitHub Bot commented on DRILL-4455:
---------------------------------------

GitHub user StevenMPhillips opened a pull request:

    https://github.com/apache/drill/pull/398

    DRILL-4455: Depend on Apache Arrow

    Remove the vector and memory modules
    Replace most instances of TypeProtos.MajorType, TypeProtos.MinorType etc
      with corresponding org.apache.arrow.types.Types class.
    The code for serializing and deserializing vectors is still in the Drill code-base
      and still uses the old TypeProtos classes. The class MajorTypeHelper is used
      to convert between the two sets of classes.
    The old load and getMetadata classes in ValueVector are now found in a corresponding
      ValueVectorHelper class

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StevenMPhillips/drill arrow9

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/398.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #398
    
----
commit 91790c43f2939a028e05f8c67093d43e96fe9caa
Author: Steven Phillips <st...@dremio.com>
Date:   2016-03-01T01:05:23Z

    DRILL-4455: Depend on Apache Arrow
    
    Remove the vector and memory modules
    Replace most instances of TypeProtos.MajorType, TypeProtos.MinorType etc
      with corresponding org.apache.arrow.types.Types class.
    The code for serializing and deserializing vectors is still in the Drill code-base
      and still uses the old TypeProtos classes. The class MajorTypeHelper is used
      to convert between the two sets of classes.
    The old load and getMetadata classes in ValueVector are now found in a corresponding
      ValueVectorHelper class

----


> Depend on Apache Arrow for Vector and Memory
> --------------------------------------------
>
>                 Key: DRILL-4455
>                 URL: https://issues.apache.org/jira/browse/DRILL-4455
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Steven Phillips
>            Assignee: Steven Phillips
>             Fix For: 1.7.0
>
>
> The code for value vectors and memory has been split and contributed to the apache arrow repository. In order to help this project advance, Drill should depend on the arrow project instead of internal value vector code.
> This change will require recompiling any external code, such as UDFs and StoragePlugins. The changes will mainly just involve renaming the classes to the org.apache.arrow namespace.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)