[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #984: SOLR-12217: Support shards.preference for individual shard requests

[GitBox <gi...@apache.org>]

HoustonPutman commented on a change in pull request #984: SOLR-12217: Support shards.preference for individual shard requests
URL: https://github.com/apache/lucene-solr/pull/984#discussion_r341214650
 
 

 ##########
 File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java
 ##########
 @@ -651,6 +659,13 @@ protected RouteException getRouteException(SolrException.ErrorCode serverError,
           }
         }
       }
+
+      // Sort the non-leader replicas according to the request parameters
+      replicaListTransformer.transform(urls);
 
 Review comment:
   Mainly for consistency. I guess it's mostly a no-op, since the leader is always going to be first anyways (if a leader exists).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org