You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ma...@apache.org on 2014/01/12 20:16:20 UTC
svn commit: r1557602 -
/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/cpdsadapter/PStmtKeyCPDS.java
Author: markt
Date: Sun Jan 12 19:16:20 2014
New Revision: 1557602
URL: http://svn.apache.org/r1557602
Log:
Reduce FindBugs warnings
Take defensive copies of client provided arrays
Modified:
commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/cpdsadapter/PStmtKeyCPDS.java
Modified: commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/cpdsadapter/PStmtKeyCPDS.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/cpdsadapter/PStmtKeyCPDS.java?rev=1557602&r1=1557601&r2=1557602&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/cpdsadapter/PStmtKeyCPDS.java (original)
+++ commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/cpdsadapter/PStmtKeyCPDS.java Sun Jan 12 19:16:20 2014
@@ -64,7 +64,7 @@ public class PStmtKeyCPDS extends PStmtK
public PStmtKeyCPDS(String sql, int columnIndexes[]) {
super(sql);
- _columnIndexes = columnIndexes;
+ _columnIndexes = Arrays.copyOf(columnIndexes, columnIndexes.length);
_autoGeneratedKeys = null;
_resultSetHoldability = null;
_columnNames = null;
@@ -72,7 +72,7 @@ public class PStmtKeyCPDS extends PStmtK
public PStmtKeyCPDS(String sql, String columnNames[]) {
super(sql);
- _columnNames = columnNames;
+ _columnNames = Arrays.copyOf(columnNames, columnNames.length);
_autoGeneratedKeys = null;
_resultSetHoldability = null;
_columnIndexes = null;