You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by na...@apache.org on 2010/05/08 23:02:08 UTC
svn commit: r942470 - in /tuscany/sca-java-1.x/trunk/modules:
domain-manager/src/main/java/org/apache/tuscany/sca/domain/manager/launcher/
implementation-node-runtime/src/main/java/org/apache/tuscany/sca/implementation/node/launcher/
Author: nash
Date: Sat May 8 21:02:07 2010
New Revision: 942470
URL: http://svn.apache.org/viewvc?rev=942470&view=rev
Log:
Prevent bootstrap launcher from changing caller's classloader setting (TUSCANY-3551)
Modified:
tuscany/sca-java-1.x/trunk/modules/domain-manager/src/main/java/org/apache/tuscany/sca/domain/manager/launcher/DomainManagerLauncherBootstrap.java
tuscany/sca-java-1.x/trunk/modules/implementation-node-runtime/src/main/java/org/apache/tuscany/sca/implementation/node/launcher/NodeImplementationDaemonBootstrap.java
tuscany/sca-java-1.x/trunk/modules/implementation-node-runtime/src/main/java/org/apache/tuscany/sca/implementation/node/launcher/NodeImplementationLauncherBootstrap.java
Modified: tuscany/sca-java-1.x/trunk/modules/domain-manager/src/main/java/org/apache/tuscany/sca/domain/manager/launcher/DomainManagerLauncherBootstrap.java
URL: http://svn.apache.org/viewvc/tuscany/sca-java-1.x/trunk/modules/domain-manager/src/main/java/org/apache/tuscany/sca/domain/manager/launcher/DomainManagerLauncherBootstrap.java?rev=942470&r1=942469&r2=942470&view=diff
==============================================================================
--- tuscany/sca-java-1.x/trunk/modules/domain-manager/src/main/java/org/apache/tuscany/sca/domain/manager/launcher/DomainManagerLauncherBootstrap.java (original)
+++ tuscany/sca-java-1.x/trunk/modules/domain-manager/src/main/java/org/apache/tuscany/sca/domain/manager/launcher/DomainManagerLauncherBootstrap.java Sat May 8 21:02:07 2010
@@ -48,7 +48,6 @@ public class DomainManagerLauncherBootst
public void start() {
threadContextClassLoader = Thread.currentThread().getContextClassLoader();
- boolean started = false;
try {
Thread.currentThread().setContextClassLoader(runtimeClassLoader);
SCANodeFactory factory = SCANodeFactory.newInstance();
@@ -58,12 +57,8 @@ public class DomainManagerLauncherBootst
// Set the domain manager's root directory
DomainManagerConfiguration domainManagerConfiguration = ((SCAClient) node).getService(DomainManagerConfiguration.class, "DomainManagerConfigurationComponent");
domainManagerConfiguration.setRootDirectory(rootDirectory);
-
- started = true;
} finally {
- if (!started) {
- Thread.currentThread().setContextClassLoader(threadContextClassLoader);
- }
+ Thread.currentThread().setContextClassLoader(threadContextClassLoader);
}
}
Modified: tuscany/sca-java-1.x/trunk/modules/implementation-node-runtime/src/main/java/org/apache/tuscany/sca/implementation/node/launcher/NodeImplementationDaemonBootstrap.java
URL: http://svn.apache.org/viewvc/tuscany/sca-java-1.x/trunk/modules/implementation-node-runtime/src/main/java/org/apache/tuscany/sca/implementation/node/launcher/NodeImplementationDaemonBootstrap.java?rev=942470&r1=942469&r2=942470&view=diff
==============================================================================
--- tuscany/sca-java-1.x/trunk/modules/implementation-node-runtime/src/main/java/org/apache/tuscany/sca/implementation/node/launcher/NodeImplementationDaemonBootstrap.java (original)
+++ tuscany/sca-java-1.x/trunk/modules/implementation-node-runtime/src/main/java/org/apache/tuscany/sca/implementation/node/launcher/NodeImplementationDaemonBootstrap.java Sat May 8 21:02:07 2010
@@ -44,16 +44,12 @@ public class NodeImplementationDaemonBoo
public void start() {
threadContextClassLoader = Thread.currentThread().getContextClassLoader();
- boolean started = false;
try {
Thread.currentThread().setContextClassLoader(runtimeClassLoader);
SCANodeFactory factory = SCANodeFactory.newInstance();
daemon = factory.createSCANodeFromClassLoader("NodeDaemon.composite", threadContextClassLoader);
- started = true;
} finally {
- if (!started) {
- Thread.currentThread().setContextClassLoader(threadContextClassLoader);
- }
+ Thread.currentThread().setContextClassLoader(threadContextClassLoader);
}
}
Modified: tuscany/sca-java-1.x/trunk/modules/implementation-node-runtime/src/main/java/org/apache/tuscany/sca/implementation/node/launcher/NodeImplementationLauncherBootstrap.java
URL: http://svn.apache.org/viewvc/tuscany/sca-java-1.x/trunk/modules/implementation-node-runtime/src/main/java/org/apache/tuscany/sca/implementation/node/launcher/NodeImplementationLauncherBootstrap.java?rev=942470&r1=942469&r2=942470&view=diff
==============================================================================
--- tuscany/sca-java-1.x/trunk/modules/implementation-node-runtime/src/main/java/org/apache/tuscany/sca/implementation/node/launcher/NodeImplementationLauncherBootstrap.java (original)
+++ tuscany/sca-java-1.x/trunk/modules/implementation-node-runtime/src/main/java/org/apache/tuscany/sca/implementation/node/launcher/NodeImplementationLauncherBootstrap.java Sat May 8 21:02:07 2010
@@ -50,15 +50,11 @@ public class NodeImplementationLauncherB
public void start() {
threadContextClassLoader = Thread.currentThread().getContextClassLoader();
- boolean started = false;
try {
Thread.currentThread().setContextClassLoader(runtimeClassLoader);
delegate.start();
- started = true;
} finally {
- if (!started) {
- Thread.currentThread().setContextClassLoader(threadContextClassLoader);
- }
+ Thread.currentThread().setContextClassLoader(threadContextClassLoader);
}
}