You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/07/02 03:30:31 UTC

[GitHub] [rocketmq-client-cpp] SRC-xiaojin commented on a diff in pull request #427: Watermark

SRC-xiaojin commented on code in PR #427:
URL: https://github.com/apache/rocketmq-client-cpp/pull/427#discussion_r912314070


##########
src/transport/TcpTransport.cpp:
##########
@@ -277,6 +281,10 @@ void TcpTransport::readNextMessageIntCallback(BufferEvent* event, TcpTransport*
 
       transport->messageReceived(msg, event->getPeerAddrPort());
     }
+    /**
+     * reset read water mark to 4
+     */
+    event->setWatermark(EV_READ, 4, 0);

Review Comment:
   at line 259, the water matk is already 4
   so I think need reset read water mark to 4 after received whole data and user's callback



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org