[GitHub] [flink] luoyuxia commented on a diff in pull request #19742: [FLINK-27651][table] Support CREATE FUNCTION USING JAR syntax

[GitBox <gi...@apache.org>]

luoyuxia commented on code in PR #19742:
URL: https://github.com/apache/flink/pull/19742#discussion_r892279638


##########
flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl:
##########
@@ -305,9 +306,52 @@ SqlCreate SqlCreateFunction(Span s, boolean replace, boolean isTemporary) :
             <PYTHON>   { functionLanguage = "PYTHON"; }
         )
     ]
+    [ <USING>  {
+        if ("SQL".equals(functionLanguage) || "PYTHON".equals(functionLanguage)) {
+            throw new ParseException(
+                String.format("USING JAR syntax is not applicable to %s language.", functionLanguage));
+        }
+        List<SqlNode> list = new ArrayList<SqlNode>();

Review Comment:
   Would it be better use a more meaningful name instead of `list`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org