You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/03/27 02:18:21 UTC

[GitHub] [hbase] shenshengli opened a new pull request #1370: HBASE-24053 Correct some errors to make it available in hbase2

shenshengli opened a new pull request #1370: HBASE-24053 Correct some errors to make it available in hbase2
URL: https://github.com/apache/hbase/pull/1370
 
 
   Re-pull request

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] shenshengli edited a comment on issue #1370: HBASE-24053 Correct some errors to make it available in hbase2

Posted by GitBox <gi...@apache.org>.
shenshengli edited a comment on issue #1370: HBASE-24053 Correct some errors to make it available in hbase2
URL: https://github.com/apache/hbase/pull/1370#issuecomment-606981005
 
 
   I didn't test the master branch, and my test environment was version 2.0.1, I don't think the script changes will involve much.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache-HBase commented on issue #1370: HBASE-24053 Correct some errors to make it available in hbase2

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1370: HBASE-24053 Correct some errors to make it available in hbase2
URL: https://github.com/apache/hbase/pull/1370#issuecomment-604781971
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 33s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   ||| _ master Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   | -0 :warning: |  rubocop  |   0m  4s |  The patch generated 2 new + 19 unchanged - 1 fixed = 21 total (was 20)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 16s |  The patch does not generate ASF License warnings.  |
   |  |   |   2m 14s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1370/1/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1370 |
   | Optional Tests | dupname asflicense rubocop |
   | uname | Linux e687fe14aa54 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / eb1fec1c53 |
   | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1370/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt |
   | Max. process+thread count | 46 (vs. ulimit of 10000) |
   | modules | C: . U: . |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1370/1/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) rubocop=0.80.0 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache-HBase commented on issue #1370: HBASE-24053 Correct some errors to make it available in hbase2

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1370: HBASE-24053 Correct some errors to make it available in hbase2
URL: https://github.com/apache/hbase/pull/1370#issuecomment-604781816
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 30s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   ||| _ Other Tests _ |
   |  |   |   1m 37s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1370/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1370 |
   | Optional Tests |  |
   | uname | Linux 2896e9867aa6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / eb1fec1c53 |
   | Max. process+thread count | 56 (vs. ulimit of 10000) |
   | modules | C: . U: . |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1370/1/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] shenshengli commented on issue #1370: HBASE-24053 Correct some errors to make it available in hbase2

Posted by GitBox <gi...@apache.org>.
shenshengli commented on issue #1370: HBASE-24053 Correct some errors to make it available in hbase2
URL: https://github.com/apache/hbase/pull/1370#issuecomment-606981005
 
 
   > 我尝试运行区域脚本并得到以下信息:
   > 
   > ```
   > ^[[ONameError: uninitialized constant IOException
   > Did you mean?  Exception
   >                     const_missing at org/jruby/RubyModule.java:3372
   >   block in ./bin/region_status.rb at ./bin/region_status.rb:105
   >                              loop at org/jruby/RubyKernel.java:1316
   >                            <main> at ./bin/region_status.rb:100
   > ```
   > 
   > 让我测试w /补丁到位。
   > 
   > 这是用于master分支和branch-2吗?
   
   
   
   > 我尝试运行区域脚本并得到以下信息:
   > 
   > ```
   > ^[[ONameError: uninitialized constant IOException
   > Did you mean?  Exception
   >                     const_missing at org/jruby/RubyModule.java:3372
   >   block in ./bin/region_status.rb at ./bin/region_status.rb:105
   >                              loop at org/jruby/RubyKernel.java:1316
   >                            <main> at ./bin/region_status.rb:100
   > ```
   > 
   > 让我测试w /补丁到位。
   > 
   > 这是用于master分支和branch-2吗?
   
   I didn't test the master branch, and my test environment was version 2.0.1, I don't think the script changes will involve much.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache-HBase commented on issue #1370: HBASE-24053 Correct some errors to make it available in hbase2

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1370: HBASE-24053 Correct some errors to make it available in hbase2
URL: https://github.com/apache/hbase/pull/1370#issuecomment-604782395
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   2m 54s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   ||| _ Other Tests _ |
   |  |   |   4m  0s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1370/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1370 |
   | Optional Tests |  |
   | uname | Linux 7fffb8fc4f24 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / eb1fec1c53 |
   | Max. process+thread count | 41 (vs. ulimit of 10000) |
   | modules | C: . U: . |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1370/1/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] saintstack commented on issue #1370: HBASE-24053 Correct some errors to make it available in hbase2

Posted by GitBox <gi...@apache.org>.
saintstack commented on issue #1370: HBASE-24053 Correct some errors to make it available in hbase2
URL: https://github.com/apache/hbase/pull/1370#issuecomment-606708296
 
 
   I tried running the region script and got this:
   
   ```
   ^[[ONameError: uninitialized constant IOException
   Did you mean?  Exception
                       const_missing at org/jruby/RubyModule.java:3372
     block in ./bin/region_status.rb at ./bin/region_status.rb:105
                                loop at org/jruby/RubyKernel.java:1316
                              <main> at ./bin/region_status.rb:100
   ```
   
   Let me test w/ patch in place.
   
   Is this for master branch and branch-2?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services