You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Jacob S. Barrett (JIRA)" <di...@incubator.apache.org> on 2005/06/14 18:00:48 UTC
[jira] Created: (DIR-112) The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.
The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.
-------------------------------------------------------------------------------------
Key: DIR-112
URL: http://issues.apache.org/jira/browse/DIR-112
Project: Directory
Type: Bug
Components: General
Reporter: Jacob S. Barrett
Assigned to: Alex Karasulu
Priority: Critical
Attachments: NameTest.java, name-prefix-suffix.patch
The attached patch fixes the LdapName#getSuffix(int) method to match the one on Java 1.5. The current getSuffix returns a prefix of sorts, but not exactly that of getPrefix. This patch also contains fixes for all (hopefully) places where getSuffix(int) was called. It also corrects the JUnit test. I have also attached a JUnit test that must be compiled and run under Java 1.5 to make sure the naming classes behave the same as Java 1.5's version.
This patch does NOT change the ContextPartion's concet of suffix even though it is really a prefix. So it is called a suffix still, but it is really the prefix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (DIR-112) The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.
Posted by "Alex Karasulu (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIR-112?page=all ]
Alex Karasulu resolved DIR-112:
-------------------------------
Resolution: Fixed
> The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.
> -------------------------------------------------------------------------------------
>
> Key: DIR-112
> URL: http://issues.apache.org/jira/browse/DIR-112
> Project: Directory
> Type: Bug
> Components: General
> Reporter: Jacob S. Barrett
> Assignee: Alex Karasulu
> Priority: Critical
> Attachments: NameTest.java, NameTest.java, NameTest.java, name-prefix-suffix.patch
>
> The attached patch fixes the LdapName#getSuffix(int) method to match the one on Java 1.5. The current getSuffix returns a prefix of sorts, but not exactly that of getPrefix. This patch also contains fixes for all (hopefully) places where getSuffix(int) was called. It also corrects the JUnit test. I have also attached a JUnit test that must be compiled and run under Java 1.5 to make sure the naming classes behave the same as Java 1.5's version.
> This patch does NOT change the ContextPartion's concet of suffix even though it is really a prefix. So it is called a suffix still, but it is really the prefix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DIR-112) The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.
Posted by "Alex Karasulu (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIR-112?page=comments#action_12313802 ]
Alex Karasulu commented on DIR-112:
-----------------------------------
Sorry can't apply this (really want to though) because it binds us to 1.5 with the test case. All users will have to run builds using the 1.5 jdk. Can you generate the results of using the JDK 1.5 LdapName and use them (generated values) as String based expected values? This way there is no 1.5 dependency and the compilations will work for everyone ;).
> The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.
> -------------------------------------------------------------------------------------
>
> Key: DIR-112
> URL: http://issues.apache.org/jira/browse/DIR-112
> Project: Directory
> Type: Bug
> Components: General
> Reporter: Jacob S. Barrett
> Assignee: Alex Karasulu
> Priority: Critical
> Attachments: NameTest.java, name-prefix-suffix.patch
>
> The attached patch fixes the LdapName#getSuffix(int) method to match the one on Java 1.5. The current getSuffix returns a prefix of sorts, but not exactly that of getPrefix. This patch also contains fixes for all (hopefully) places where getSuffix(int) was called. It also corrects the JUnit test. I have also attached a JUnit test that must be compiled and run under Java 1.5 to make sure the naming classes behave the same as Java 1.5's version.
> This patch does NOT change the ContextPartion's concet of suffix even though it is really a prefix. So it is called a suffix still, but it is really the prefix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DIR-112) The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.
Posted by "Jacob S. Barrett (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIR-112?page=all ]
Jacob S. Barrett updated DIR-112:
---------------------------------
Attachment: NameTest.java
This one replaces the 1.5 results with strings.
> The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.
> -------------------------------------------------------------------------------------
>
> Key: DIR-112
> URL: http://issues.apache.org/jira/browse/DIR-112
> Project: Directory
> Type: Bug
> Components: General
> Reporter: Jacob S. Barrett
> Assignee: Alex Karasulu
> Priority: Critical
> Attachments: NameTest.java, NameTest.java, name-prefix-suffix.patch
>
> The attached patch fixes the LdapName#getSuffix(int) method to match the one on Java 1.5. The current getSuffix returns a prefix of sorts, but not exactly that of getPrefix. This patch also contains fixes for all (hopefully) places where getSuffix(int) was called. It also corrects the JUnit test. I have also attached a JUnit test that must be compiled and run under Java 1.5 to make sure the naming classes behave the same as Java 1.5's version.
> This patch does NOT change the ContextPartion's concet of suffix even though it is really a prefix. So it is called a suffix still, but it is really the prefix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DIR-112) The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.
Posted by "Jacob S. Barrett (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIR-112?page=all ]
Jacob S. Barrett updated DIR-112:
---------------------------------
Attachment: NameTest.java
Tests Apaching's LdapName against Sun's LdapName for consitency. Depends on Java 1.5.
> The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.
> -------------------------------------------------------------------------------------
>
> Key: DIR-112
> URL: http://issues.apache.org/jira/browse/DIR-112
> Project: Directory
> Type: Bug
> Components: General
> Reporter: Jacob S. Barrett
> Assignee: Alex Karasulu
> Priority: Critical
> Attachments: NameTest.java, name-prefix-suffix.patch
>
> The attached patch fixes the LdapName#getSuffix(int) method to match the one on Java 1.5. The current getSuffix returns a prefix of sorts, but not exactly that of getPrefix. This patch also contains fixes for all (hopefully) places where getSuffix(int) was called. It also corrects the JUnit test. I have also attached a JUnit test that must be compiled and run under Java 1.5 to make sure the naming classes behave the same as Java 1.5's version.
> This patch does NOT change the ContextPartion's concet of suffix even though it is really a prefix. So it is called a suffix still, but it is really the prefix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DIR-112) The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.
Posted by "Jacob S. Barrett (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIR-112?page=all ]
Jacob S. Barrett updated DIR-112:
---------------------------------
Attachment: NameTest.java
Replaces all other versions of this file. Checks against the com.sun.jndi.ldap.LdapName class in Java 1.4.
> The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.
> -------------------------------------------------------------------------------------
>
> Key: DIR-112
> URL: http://issues.apache.org/jira/browse/DIR-112
> Project: Directory
> Type: Bug
> Components: General
> Reporter: Jacob S. Barrett
> Assignee: Alex Karasulu
> Priority: Critical
> Attachments: NameTest.java, NameTest.java, NameTest.java, name-prefix-suffix.patch
>
> The attached patch fixes the LdapName#getSuffix(int) method to match the one on Java 1.5. The current getSuffix returns a prefix of sorts, but not exactly that of getPrefix. This patch also contains fixes for all (hopefully) places where getSuffix(int) was called. It also corrects the JUnit test. I have also attached a JUnit test that must be compiled and run under Java 1.5 to make sure the naming classes behave the same as Java 1.5's version.
> This patch does NOT change the ContextPartion's concet of suffix even though it is really a prefix. So it is called a suffix still, but it is really the prefix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (DIR-112) The implementation of
LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.
Posted by "Emmanuel Lecharny (JIRA)" <di...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/DIR-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny closed DIR-112.
---------------------------------
> The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.
> -------------------------------------------------------------------------------------
>
> Key: DIR-112
> URL: https://issues.apache.org/jira/browse/DIR-112
> Project: Directory
> Issue Type: Bug
> Components: miscellaneous
> Reporter: Jacob S. Barrett
> Assignee: Alex Karasulu
> Priority: Critical
> Attachments: name-prefix-suffix.patch, NameTest.java, NameTest.java, NameTest.java
>
>
> The attached patch fixes the LdapName#getSuffix(int) method to match the one on Java 1.5. The current getSuffix returns a prefix of sorts, but not exactly that of getPrefix. This patch also contains fixes for all (hopefully) places where getSuffix(int) was called. It also corrects the JUnit test. I have also attached a JUnit test that must be compiled and run under Java 1.5 to make sure the naming classes behave the same as Java 1.5's version.
> This patch does NOT change the ContextPartion's concet of suffix even though it is really a prefix. So it is called a suffix still, but it is really the prefix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIR-112) The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.
Posted by "Trustin Lee (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIR-112?page=comments#action_12324520 ]
Trustin Lee commented on DIR-112:
---------------------------------
Alex, does your fix include changes in ContextPartition.getSuffix( boolean )? It should be reopen if it doesn't.
> The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.
> -------------------------------------------------------------------------------------
>
> Key: DIR-112
> URL: http://issues.apache.org/jira/browse/DIR-112
> Project: Directory
> Type: Bug
> Components: General
> Reporter: Jacob S. Barrett
> Assignee: Alex Karasulu
> Priority: Critical
> Attachments: NameTest.java, NameTest.java, NameTest.java, name-prefix-suffix.patch
>
> The attached patch fixes the LdapName#getSuffix(int) method to match the one on Java 1.5. The current getSuffix returns a prefix of sorts, but not exactly that of getPrefix. This patch also contains fixes for all (hopefully) places where getSuffix(int) was called. It also corrects the JUnit test. I have also attached a JUnit test that must be compiled and run under Java 1.5 to make sure the naming classes behave the same as Java 1.5's version.
> This patch does NOT change the ContextPartion's concet of suffix even though it is really a prefix. So it is called a suffix still, but it is really the prefix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DIR-112) The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.
Posted by "Jacob S. Barrett (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIR-112?page=comments#action_12313603 ]
Jacob S. Barrett commented on DIR-112:
--------------------------------------
Replaces DIRLDAP-37 (http://issues.apache.org/jira/browse/DIRLDAP-37).
> The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.
> -------------------------------------------------------------------------------------
>
> Key: DIR-112
> URL: http://issues.apache.org/jira/browse/DIR-112
> Project: Directory
> Type: Bug
> Components: General
> Reporter: Jacob S. Barrett
> Assignee: Alex Karasulu
> Priority: Critical
> Attachments: NameTest.java, name-prefix-suffix.patch
>
> The attached patch fixes the LdapName#getSuffix(int) method to match the one on Java 1.5. The current getSuffix returns a prefix of sorts, but not exactly that of getPrefix. This patch also contains fixes for all (hopefully) places where getSuffix(int) was called. It also corrects the JUnit test. I have also attached a JUnit test that must be compiled and run under Java 1.5 to make sure the naming classes behave the same as Java 1.5's version.
> This patch does NOT change the ContextPartion's concet of suffix even though it is really a prefix. So it is called a suffix still, but it is really the prefix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DIR-112) The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.
Posted by "Jacob S. Barrett (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIR-112?page=all ]
Jacob S. Barrett updated DIR-112:
---------------------------------
Attachment: name-prefix-suffix.patch
Patch to correct getSuffix.
> The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.
> -------------------------------------------------------------------------------------
>
> Key: DIR-112
> URL: http://issues.apache.org/jira/browse/DIR-112
> Project: Directory
> Type: Bug
> Components: General
> Reporter: Jacob S. Barrett
> Assignee: Alex Karasulu
> Priority: Critical
> Attachments: NameTest.java, name-prefix-suffix.patch
>
> The attached patch fixes the LdapName#getSuffix(int) method to match the one on Java 1.5. The current getSuffix returns a prefix of sorts, but not exactly that of getPrefix. This patch also contains fixes for all (hopefully) places where getSuffix(int) was called. It also corrects the JUnit test. I have also attached a JUnit test that must be compiled and run under Java 1.5 to make sure the naming classes behave the same as Java 1.5's version.
> This patch does NOT change the ContextPartion's concet of suffix even though it is really a prefix. So it is called a suffix still, but it is really the prefix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira