You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by hl...@apache.org on 2014/02/04 18:32:08 UTC
[1/2] git commit: TAP5-2271: Glyphyicon component should support
informal parameters
Updated Branches:
refs/heads/master 875927fd2 -> e26d6e312
TAP5-2271: Glyphyicon component should support informal parameters
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/b1bd74da
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/b1bd74da
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/b1bd74da
Branch: refs/heads/master
Commit: b1bd74da72c363a8d9c98aa79f64155d9a92ce01
Parents: 875927f
Author: Howard M. Lewis Ship <hl...@apache.org>
Authored: Mon Jan 13 10:31:28 2014 -0800
Committer: Howard M. Lewis Ship <hl...@apache.org>
Committed: Tue Feb 4 12:28:06 2014 -0500
----------------------------------------------------------------------
.../apache/tapestry5/corelib/components/Glyphicon.java | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/b1bd74da/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Glyphicon.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Glyphicon.java b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Glyphicon.java
index 66ca5ba..6e697d6 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Glyphicon.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Glyphicon.java
@@ -15,15 +15,19 @@
package org.apache.tapestry5.corelib.components;
import org.apache.tapestry5.BindingConstants;
+import org.apache.tapestry5.ComponentResources;
import org.apache.tapestry5.MarkupWriter;
import org.apache.tapestry5.annotations.Parameter;
+import org.apache.tapestry5.annotations.SupportsInformalParameters;
+import org.apache.tapestry5.ioc.annotations.Inject;
/**
* Renders a {@code <span>} tag with the CSS class to select a <a href="http://getbootstrap.com/components/#glyphicons">Bootstrap Glyphicon</a>.
*
- * @since 5.4
* @tapestrydoc
+ * @since 5.4
*/
+@SupportsInformalParameters
public class Glyphicon
{
/**
@@ -32,10 +36,14 @@ public class Glyphicon
@Parameter(required = true, allowNull = false, defaultPrefix = BindingConstants.LITERAL)
String name;
+ @Inject
+ ComponentResources resources;
+
boolean beginRender(MarkupWriter writer)
{
writer.element("span",
"class", "glyphicon glyphicon-" + name);
+ resources.renderInformalParameters(writer);
writer.end();
return false;
[2/2] git commit: Clarify logic about which element is the event
source in an AjaxFormLoop update
Posted by hl...@apache.org.
Clarify logic about which element is the event source in an AjaxFormLoop update
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/e26d6e31
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/e26d6e31
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/e26d6e31
Branch: refs/heads/master
Commit: e26d6e312cf6062f82e62b39df127fb9cc059d77
Parents: b1bd74d
Author: Howard M. Lewis Ship <hl...@apache.org>
Authored: Tue Feb 4 12:31:55 2014 -0500
Committer: Howard M. Lewis Ship <hl...@apache.org>
Committed: Tue Feb 4 12:31:55 2014 -0500
----------------------------------------------------------------------
.../coffeescript/META-INF/modules/t5/core/ajaxformloop.coffee | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/e26d6e31/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/ajaxformloop.coffee
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/ajaxformloop.coffee b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/ajaxformloop.coffee
index 4818266..649dd6d 100644
--- a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/ajaxformloop.coffee
+++ b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/ajaxformloop.coffee
@@ -72,11 +72,11 @@ define ["./dom", "./events", "./console", "./ajax"],
</#{insertionPoint.element.tagName}>
"""
- newElement = insertionPoint.insertBefore newElement
+ insertionPoint.insertBefore newElement
# Trigger this event, to inform the world that the zone-like new element has been updated
# with content.
- newElement.trigger events.zone.didUpdate
+ insertionPoint.trigger events.zone.didUpdate
return false
[2/2] git commit: Clarify logic about which element is the event
source in an AjaxFormLoop update
Posted by hl...@apache.org.
Clarify logic about which element is the event source in an AjaxFormLoop update
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/e26d6e31
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/e26d6e31
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/e26d6e31
Branch: refs/heads/master
Commit: e26d6e312cf6062f82e62b39df127fb9cc059d77
Parents: b1bd74d
Author: Howard M. Lewis Ship <hl...@apache.org>
Authored: Tue Feb 4 12:31:55 2014 -0500
Committer: Howard M. Lewis Ship <hl...@apache.org>
Committed: Tue Feb 4 12:31:55 2014 -0500
----------------------------------------------------------------------
.../coffeescript/META-INF/modules/t5/core/ajaxformloop.coffee | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/e26d6e31/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/ajaxformloop.coffee
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/ajaxformloop.coffee b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/ajaxformloop.coffee
index 4818266..649dd6d 100644
--- a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/ajaxformloop.coffee
+++ b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/ajaxformloop.coffee
@@ -72,11 +72,11 @@ define ["./dom", "./events", "./console", "./ajax"],
</#{insertionPoint.element.tagName}>
"""
- newElement = insertionPoint.insertBefore newElement
+ insertionPoint.insertBefore newElement
# Trigger this event, to inform the world that the zone-like new element has been updated
# with content.
- newElement.trigger events.zone.didUpdate
+ insertionPoint.trigger events.zone.didUpdate
return false