[GitHub] [hbase] Apache9 commented on a change in pull request #3140: HBASE-25720 Sync WAL stuck when prepare flush cache will prevent flus…

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #3140:
URL: https://github.com/apache/hbase/pull/3140#discussion_r637022472



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -2846,7 +2846,13 @@ protected PrepareFlushResult internalPrepareFlushCache(WAL wal, long myseqid,
     String s = "Finished memstore snapshotting " + this + ", syncing WAL and waiting on mvcc, " +
         "flushsize=" + totalSizeOfFlushableStores;
     status.setStatus(s);
-    doSyncOfUnflushedWALChanges(wal, getRegionInfo());
+
+    try {
+      doSyncOfUnflushedWALChanges(wal, getRegionInfo());
+    } catch (Throwable t) {
+      status.abort("Sync unflushed WAL changes failed: " + StringUtils.stringifyException(t));
+      fatalForFlushCache(t);

Review comment:
       Mind explaining a bit why here we need to abort the regionserver? We do not need to abort the regionserver when hitting IOException above?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org