You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/30 10:41:24 UTC
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #472: Fixing permission issues
davidjumani opened a new pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472
Fixes #463
Compute:
- [ ] SSH keys: create SSH key without specifying public key creates private key, could we make it easier for user to copy or download it? Or, simply cause a file to be downloaded after the form finishes.
Network:
- [ ] VPN users: add user causes failure (could be backend issue, or this needs to be allowed only after VPN is enabled on some network?)
- [x] After adding VPC tier it does not refresh the network/tiers list
Templates:
- [x] Edit Template and edit Template permission action show to user (restrict to owner or domain/admin?)
- [x] Copy and Delete Template show irrespective of user/account/acl checks
- [x] Setting tab show for edit/add settings to templates to non-owner/user (read-only is fine)
- [x] Download template buttons show without doing checks (only Domain Admin and regular users can modify only their own Public templates)
- [x] Users are unable to edit their template - Don't show isrouting parameter is create/edit template for users
ISOs:
- [x] Edit ISO and edit ISO permission action show to user (restrict to owner or domain/admin?)
- [x] Copy and Delete ISO show irrespective of user/account/acl checks
- [x] Download ISO button show without doing checks (only Domain Admin and regular users can modify only their own Public templates)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472#issuecomment-654566816
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472#issuecomment-654186464
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472#issuecomment-654190854
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/472 (JID-2222)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472#issuecomment-652989344
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472#issuecomment-653336530
@rhtyd Good to go!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472#issuecomment-654569026
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/472 (JID-2229)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472#issuecomment-653490443
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/472 (JID-2201)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472#issuecomment-653486279
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472#issuecomment-654617919
@Pearl1594 are you testing as well, if so I'll merge if you're LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472#issuecomment-652278987
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472#issuecomment-654187002
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472#issuecomment-653790167
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472#issuecomment-654566560
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472#issuecomment-653790323
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472#issuecomment-652994792
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/472 (JID-2196)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472#issuecomment-652989992
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472#issuecomment-653791159
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/472 (JID-2210)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472#issuecomment-652279819
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472#issuecomment-653486578
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472#issuecomment-654621085
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472#issuecomment-652284924
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/472 (JID-2176)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472#issuecomment-654621296
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472#issuecomment-654624010
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/472 (JID-2231)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #472: Fixing permission issues
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472#issuecomment-654093239
Please merge latest master and fix any conflicts? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org