You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/25 07:21:52 UTC
[GitHub] [kafka] showuon opened a new pull request #10928: KAFKA-12993: fix memory-mgmt.html
showuon opened a new pull request #10928:
URL: https://github.com/apache/kafka/pull/10928
1. remove redundant new line
2. tag closing is wrong
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon closed pull request #10928: KAFKA-12993: fix memory-mgmt.html
Posted by GitBox <gi...@apache.org>.
showuon closed pull request #10928:
URL: https://github.com/apache/kafka/pull/10928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10928: KAFKA-12993: fix memory-mgmt.html
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10928:
URL: https://github.com/apache/kafka/pull/10928#issuecomment-868284309
@ableegoldman , please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a change in pull request #10928: KAFKA-12993: fix memory-mgmt.html
Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #10928:
URL: https://github.com/apache/kafka/pull/10928#discussion_r658532001
##########
File path: docs/streams/developer-guide/memory-mgmt.html
##########
@@ -180,9 +179,9 @@ <h2><a class="toc-backref" href="#id3">RocksDB</a><a class="headerlink" href="#r
options.setWriteBufferManager(writeBufferManager);
// These options are recommended to be set when bounding the total memory
- tableConfig.setCacheIndexAndFilterBlocksWithHighPriority(true);</code><a href="#fn2" id="ref2"><sup>2</sup></a><code>
+ tableConfig.setCacheIndexAndFilterBlocksWithHighPriority(true);<code><a href="#fn2" id="ref2"><sup>2</sup></a></code>
tableConfig.setPinTopLevelIndexAndFilter(true);
- tableConfig.setBlockSize(BLOCK_SIZE);</code><a href="#fn3" id="ref3"><sup>3</sup></a><code>
+ tableConfig.setBlockSize(BLOCK_SIZE);<code><a href="#fn3" id="ref3"><sup>3</sup></a></code>
Review comment:
fix 2: `code` tag start and end is wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10928: KAFKA-12993: fix memory-mgmt.html
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10928:
URL: https://github.com/apache/kafka/pull/10928#issuecomment-868871415
Please ignore this PR. I was wrong about the code tag. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a change in pull request #10928: KAFKA-12993: fix memory-mgmt.html
Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #10928:
URL: https://github.com/apache/kafka/pull/10928#discussion_r658531589
##########
File path: docs/streams/developer-guide/memory-mgmt.html
##########
@@ -161,12 +161,11 @@ <h2><a class="toc-backref" href="#id3">RocksDB</a><a class="headerlink" href="#r
<pre class="line-numbers"><code class="language-bash"># example: install jemalloc (on Debian)
$ apt install -y libjemalloc-dev
# set LD_PRELOAD before you start your Kafka Streams application
-$ export LD_PRELOAD="/usr/lib/x86_64-linux-gnu/libjemalloc.so”
- </code></pre>
+$ export LD_PRELOAD="/usr/lib/x86_64-linux-gnu/libjemalloc.so"</code></pre>
Review comment:
fix 1: remove redundant new line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org