You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2012/09/19 20:27:22 UTC

Review Request: Fix for os::isfile

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7174/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Description
-------

One liner, here's how python does os.path.isfile:
http://svn.python.org/view/*checkout*/python/trunk/Lib/genericpath.py?content-type=text%2Fplain


Diffs
-----

  third_party/libprocess/include/stout/os.hpp c9c2d23 

Diff: https://reviews.apache.org/r/7174/diff/


Testing
-------

make check


Thanks,

Ben Mahler

Re: Review Request: Fix for os::isfile

Posted by Benjamin Hindman <be...@berkeley.edu>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7174/#review11709
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On Sept. 19, 2012, 6:27 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7174/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2012, 6:27 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Description
> -------
> 
> One liner, here's how python does os.path.isfile:
> http://svn.python.org/view/*checkout*/python/trunk/Lib/genericpath.py?content-type=text%2Fplain
> 
> 
> Diffs
> -----
> 
>   third_party/libprocess/include/stout/os.hpp c9c2d23 
> 
> Diff: https://reviews.apache.org/r/7174/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>