You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2012/05/08 13:21:33 UTC
Review Request: SQOOP-484: Update troubleshooting guide section about MySQL
and TINYINT(1) columns
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5065/
-----------------------------------------------------------
Review request for Sqoop and Kathleen Ting.
Summary
-------
I've updated corresponding section in Troubleshooting guide.
This addresses bug SQOOP-484.
https://issues.apache.org/jira/browse/SQOOP-484
Diffs
-----
/src/docs/user/troubleshooting.txt 1335407
Diff: https://reviews.apache.org/r/5065/diff
Testing
-------
Thanks,
Jarek
Re: Review Request: SQOOP-484: Update troubleshooting guide section about
MySQL and TINYINT(1) columns
Posted by Kathleen Ting <ka...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5065/#review7833
-----------------------------------------------------------
Ship it!
Looks good. Thanks Jarcec.
- Kathleen
On 2012-05-12 14:07:22, Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5065/
> -----------------------------------------------------------
>
> (Updated 2012-05-12 14:07:22)
>
>
> Review request for Sqoop and Kathleen Ting.
>
>
> Summary
> -------
>
> I've updated corresponding section in Troubleshooting guide.
>
>
> This addresses bug SQOOP-484.
> https://issues.apache.org/jira/browse/SQOOP-484
>
>
> Diffs
> -----
>
> /src/docs/user/troubleshooting.txt 1336267
>
> Diff: https://reviews.apache.org/r/5065/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek
>
>
Re: Review Request: SQOOP-484: Update troubleshooting guide section about
MySQL and TINYINT(1) columns
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5065/
-----------------------------------------------------------
(Updated 2012-05-12 14:07:22.638820)
Review request for Sqoop and Kathleen Ting.
Changes
-------
Hi Kate,
thank you very much for your feedback. I appreciate your help with improving my English :-)
I've incorporated all your suggestions and uploaded new patch.
Jarcec
Summary
-------
I've updated corresponding section in Troubleshooting guide.
This addresses bug SQOOP-484.
https://issues.apache.org/jira/browse/SQOOP-484
Diffs (updated)
-----
/src/docs/user/troubleshooting.txt 1336267
Diff: https://reviews.apache.org/r/5065/diff
Testing
-------
Thanks,
Jarek
Re: Review Request: SQOOP-484: Update troubleshooting guide section about
MySQL and TINYINT(1) columns
Posted by Kathleen Ting <ka...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5065/#review7751
-----------------------------------------------------------
Jarcec - good work. Some feedback.
1.) "This is because by default MySQL" needs a 'the', i.e. "This is because by default the MySQL"
2.) How about "A more clean solution" instead of "Most cleaner solution"?
3.) How about expanding on "Another solution would be to use sqoop ability to override default mapping." - e.g. Another solution would be to explicitly override the column mapping for the datatype TINYINT(1) column. For example, if the column name is foo, then pass the following option to Sqoop during import: --map-column-hive foo=tinyint. In the case of non-Hive imports to HDFS, use --map-column-java foo=integer.
- Kathleen
On 2012-05-08 11:21:33, Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5065/
> -----------------------------------------------------------
>
> (Updated 2012-05-08 11:21:33)
>
>
> Review request for Sqoop and Kathleen Ting.
>
>
> Summary
> -------
>
> I've updated corresponding section in Troubleshooting guide.
>
>
> This addresses bug SQOOP-484.
> https://issues.apache.org/jira/browse/SQOOP-484
>
>
> Diffs
> -----
>
> /src/docs/user/troubleshooting.txt 1335407
>
> Diff: https://reviews.apache.org/r/5065/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek
>
>