You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2019/01/25 20:41:51 UTC

[GitHub] eolivelli commented on a change in pull request #1917: Ignore usage of localNode in PlacementPolicy.

eolivelli commented on a change in pull request #1917: Ignore usage of localNode in PlacementPolicy.
URL: https://github.com/apache/bookkeeper/pull/1917#discussion_r251129250
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicy.java
 ##########
 @@ -56,18 +56,20 @@ protected RackawareEnsemblePlacementPolicy initialize(DNSToSwitchMapping dnsReso
                                                           int maxWeightMultiple,
                                                           int minNumRacksPerWriteQuorum,
                                                           boolean enforceMinNumRacksPerWriteQuorum,
+                                                          boolean ignoreLocalNodeInPlacementPolicy,
 
 Review comment:
   In the near future we should refactor this method and introduce a single bean or anyhow reduce the number of parameters.
   Not blocker for this change

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services