You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2026/04/02 12:46:56 UTC

Re: [PR] KYLIN-4337 Global domain dict for Spark build engine [kylin]

codecov-commenter commented on PR #1057:
URL: https://github.com/apache/kylin/pull/1057#issuecomment-4177625465

   ## [Codecov](https://app.codecov.io/gh/apache/kylin/pull/1057?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `9.73451%` with `102 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 25.04%. Comparing base ([`3777021`](https://app.codecov.io/gh/apache/kylin/commit/37770217b2a9d7a62a40acae74fe77ea1d170b2a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11a80bb`](https://app.codecov.io/gh/apache/kylin/commit/11a80bbc34df94523336feea42ab777ed6280b32?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/kylin/pull/1057?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...be/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://app.codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree&filepath=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FCubeDescTiretreeGlobalDomainDictUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjVGlyZXRyZWVHbG9iYWxEb21haW5EaWN0VXRpbC5qYXZh) | 0.00% | [67 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...va/org/apache/kylin/cube/model/DictionaryDesc.java](https://app.codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree&filepath=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FDictionaryDesc.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0RpY3Rpb25hcnlEZXNjLmphdmE=) | 10.00% | [8 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://app.codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree&filepath=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FCubeDesc.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/kylin/metadata/model/DataModelDesc.java](https://app.codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree&filepath=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FDataModelDesc.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsRGVzYy5qYXZh) | 25.00% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/kylin/measure/bitmap/BitmapMeasureType.java](https://app.codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree&filepath=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fbitmap%2FBitmapMeasureType.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwTWVhc3VyZVR5cGUuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://app.codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree&filepath=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | 50.00% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...lin/cube/model/validation/rule/DictionaryRule.java](https://app.codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree&filepath=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2Fvalidation%2Frule%2FDictionaryRule.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9EaWN0aW9uYXJ5UnVsZS5qYXZh) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/kylin/engine/spark/SparkExecutable.java](https://app.codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree&filepath=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkExecutable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtFeGVjdXRhYmxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://app.codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree&filepath=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fcommon%2FAbstractHadoopJob.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1057      +/-   ##
   ============================================
   + Coverage     25.00%   25.04%   +0.03%     
   - Complexity     6180     6221      +41     
   ============================================
     Files          1438     1439       +1     
     Lines         87669    87773     +104     
     Branches      12256    12272      +16     
   ============================================
   + Hits          21926    21981      +55     
   - Misses        63593    63636      +43     
   - Partials       2150     2156       +6     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kylin/pull/1057?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org