You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Behm (Code Review)" <ge...@cloudera.org> on 2017/02/21 23:02:41 UTC

[Impala-ASF-CR] IMPALA-4959: Avoid picking up the system's boost cmake module

Alex Behm has uploaded a new patch set (#3).

Change subject: IMPALA-4959: Avoid picking up the system's boost cmake module
......................................................................

IMPALA-4959: Avoid picking up the system's boost cmake module

In some systems with an old boost installed system-wide the impala build
would fail with something like:

CMake Error at /usr/lib64/boost/BoostConfig.cmake:64 (get_target_property):
  get_target_property() called with non-existent target
  "boost_thread-shared".
Call Stack (most recent call first):
  toolchain/cmake-3.2.3-p1/share/cmake-3.2/Modules/FindBoost.cmake:206 (find_package)
  CMakeLists.txt:116 (find_package)

CMake Error at /usr/lib64/boost/BoostConfig.cmake:72 (get_target_property):
  get_target_property() called with non-existent target
  "boost_thread-shared-debug".
Call Stack (most recent call first):
  toolchain/cmake-3.2.3-p1/share/cmake-3.2/Modules/FindBoost.cmake:206 (find_package)
  CMakeLists.txt:116 (find_package)

This because, if it exists, cmake's FindBoost.cmake will look for and
use that module, even though boost's cmake build hasn't been maintained
in years and the impala build is actually configured to not use the
systems boost.

This patch sets the cmake flag Boost_NO_BOOST_CMAKE to ON, making sure
the old cmake module is not picked up.

Change-Id: I759e1a4f8f69727cc1224bf460326140fd2131a2
---
M CMakeLists.txt
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/5994/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I759e1a4f8f69727cc1224bf460326140fd2131a2
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>