You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "jackye1995 (via GitHub)" <gi...@apache.org> on 2023/06/02 19:32:01 UTC

[GitHub] [iceberg] jackye1995 commented on a diff in pull request #7731: Core: Implement adaptive split planning in core.

jackye1995 commented on code in PR #7731:
URL: https://github.com/apache/iceberg/pull/7731#discussion_r1214749370


##########
api/src/main/java/org/apache/iceberg/io/CloseableIterable.java:
##########
@@ -206,6 +206,10 @@ public O next() {
     };
   }
 
+  static <E> CloseableIterable<E> concat(CloseableIterable<E> i1, CloseableIterable<E> i2) {
+    return concat(ImmutableList.of(i1, i2));

Review Comment:
   nit: why not use `CloseableIterable<E>...`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org