[GitHub] [beam] aromanenko-dev commented on a change in pull request #11055: [BEAM-9436] improve GBK in spark structured streaming runner

[GitBox <gi...@apache.org>]

aromanenko-dev commented on a change in pull request #11055: [BEAM-9436] improve GBK in spark structured streaming runner
URL: https://github.com/apache/beam/pull/11055#discussion_r396388069
 
 

 ##########
 File path: runners/spark/src/main/java/org/apache/beam/runners/spark/structuredstreaming/translation/batch/functions/GroupAlsoByWindowViaOutputBufferFn.java
 ##########
 @@ -65,9 +65,15 @@ public GroupAlsoByWindowViaOutputBufferFn(
 
   @Override
   public Iterator<WindowedValue<KV<K, Iterable<InputT>>>> call(
-      KV<K, Iterable<WindowedValue<InputT>>> kv) throws Exception {
-    K key = kv.getKey();
-    Iterable<WindowedValue<InputT>> values = kv.getValue();
+      K key, Iterator<WindowedValue<KV<K, InputT>>> iterator) throws Exception {
+
+    // we have to meterialize the Iterator because ReduceFnRunner.processElements expects
 
 Review comment:
   typo: "meterialize" 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services