You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Thomas Mäder (JIRA)" <ji...@apache.org> on 2007/08/31 13:24:31 UTC
[jira] Created: (WICKET-909) onBeforeRender not called on
ModalWindow contents
onBeforeRender not called on ModalWindow contents
-------------------------------------------------
Key: WICKET-909
URL: https://issues.apache.org/jira/browse/WICKET-909
Project: Wicket
Issue Type: Bug
Components: wicket-extensions
Affects Versions: 1.3.0-beta3
Environment: Tomcat 5.5.1
Windows
Eclipse + wtp
Reporter: Thomas Mäder
Priority: Minor
ModalWindow.onBeforeRender contains the following code:
super.onBeforeRender();
getContent().setOutputMarkupId(true);
getContent().setVisible(shown);
This has the consequence that the content of the modal windows is still invisible when its onBeforeRender() method is called. The default implementation of onBeforeRender delegates to the window's children beforeRender() method. However, the contents beforeRender() method first checks if the component is visible, which is not the case, so the onBeforeRender() call is not propagated down the component tree.
This is a problem if the content of the modal window is something like a table, which populates itself in the onBeforeRender call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-909) onBeforeRender not called on
ModalWindow contents
Posted by "Thomas Mäder (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Mäder updated WICKET-909:
--------------------------------
Attachment: TestModal.zip
I've made this little example which shows the problem.
1) Start the application
2) click one of the "show x lines" links
3) observe: the resulting dialog is empty
4) close the dialog
5) click one of the "show x lines" links
6) observe: the dialog shows the correct number of lines
> onBeforeRender not called on ModalWindow contents
> -------------------------------------------------
>
> Key: WICKET-909
> URL: https://issues.apache.org/jira/browse/WICKET-909
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.0-beta3
> Environment: Tomcat 5.5.1
> Windows
> Eclipse + wtp
> Reporter: Thomas Mäder
> Priority: Minor
> Attachments: TestModal.zip
>
>
> ModalWindow.onBeforeRender contains the following code:
> super.onBeforeRender();
> getContent().setOutputMarkupId(true);
> getContent().setVisible(shown);
> This has the consequence that the content of the modal windows is still invisible when its onBeforeRender() method is called. The default implementation of onBeforeRender delegates to the window's children beforeRender() method. However, the contents beforeRender() method first checks if the component is visible, which is not the case, so the onBeforeRender() call is not propagated down the component tree.
> This is a problem if the content of the modal window is something like a table, which populates itself in the onBeforeRender call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-909) onBeforeRender not called on
ModalWindow contents
Posted by "Thomas Mäder (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524060 ]
Thomas Mäder commented on WICKET-909:
-------------------------------------
I haven't figured out why it works the second time.
> onBeforeRender not called on ModalWindow contents
> -------------------------------------------------
>
> Key: WICKET-909
> URL: https://issues.apache.org/jira/browse/WICKET-909
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.0-beta3
> Environment: Tomcat 5.5.1
> Windows
> Eclipse + wtp
> Reporter: Thomas Mäder
> Priority: Minor
> Attachments: TestModal.zip
>
>
> ModalWindow.onBeforeRender contains the following code:
> super.onBeforeRender();
> getContent().setOutputMarkupId(true);
> getContent().setVisible(shown);
> This has the consequence that the content of the modal windows is still invisible when its onBeforeRender() method is called. The default implementation of onBeforeRender delegates to the window's children beforeRender() method. However, the contents beforeRender() method first checks if the component is visible, which is not the case, so the onBeforeRender() call is not propagated down the component tree.
> This is a problem if the content of the modal window is something like a table, which populates itself in the onBeforeRender call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-909) onBeforeRender not called on
ModalWindow contents
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner reassigned WICKET-909:
--------------------------------------
Assignee: Matej Knopp
yeah, this is because of the behavior change i committed so that onBeforeRender is not called on none visible components
The modal window should do the onBeforeRender as a last statement, does this have any other drawbacks Matej?
> onBeforeRender not called on ModalWindow contents
> -------------------------------------------------
>
> Key: WICKET-909
> URL: https://issues.apache.org/jira/browse/WICKET-909
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.0-beta3
> Environment: Tomcat 5.5.1
> Windows
> Eclipse + wtp
> Reporter: Thomas Mäder
> Assignee: Matej Knopp
> Priority: Minor
> Attachments: TestModal.zip
>
>
> ModalWindow.onBeforeRender contains the following code:
> super.onBeforeRender();
> getContent().setOutputMarkupId(true);
> getContent().setVisible(shown);
> This has the consequence that the content of the modal windows is still invisible when its onBeforeRender() method is called. The default implementation of onBeforeRender delegates to the window's children beforeRender() method. However, the contents beforeRender() method first checks if the component is visible, which is not the case, so the onBeforeRender() call is not propagated down the component tree.
> This is a problem if the content of the modal window is something like a table, which populates itself in the onBeforeRender call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-909) onBeforeRender not called on
ModalWindow contents
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524149 ]
Matej Knopp commented on WICKET-909:
------------------------------------
I don't know about any. Will try it this weekend.
> onBeforeRender not called on ModalWindow contents
> -------------------------------------------------
>
> Key: WICKET-909
> URL: https://issues.apache.org/jira/browse/WICKET-909
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.0-beta3
> Environment: Tomcat 5.5.1
> Windows
> Eclipse + wtp
> Reporter: Thomas Mäder
> Assignee: Matej Knopp
> Priority: Minor
> Attachments: TestModal.zip
>
>
> ModalWindow.onBeforeRender contains the following code:
> super.onBeforeRender();
> getContent().setOutputMarkupId(true);
> getContent().setVisible(shown);
> This has the consequence that the content of the modal windows is still invisible when its onBeforeRender() method is called. The default implementation of onBeforeRender delegates to the window's children beforeRender() method. However, the contents beforeRender() method first checks if the component is visible, which is not the case, so the onBeforeRender() call is not propagated down the component tree.
> This is a problem if the content of the modal window is something like a table, which populates itself in the onBeforeRender call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-909) onBeforeRender not called on
ModalWindow contents
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matej Knopp resolved WICKET-909.
--------------------------------
Resolution: Fixed
Fix Version/s: 1.3.0-beta4
> onBeforeRender not called on ModalWindow contents
> -------------------------------------------------
>
> Key: WICKET-909
> URL: https://issues.apache.org/jira/browse/WICKET-909
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.0-beta3
> Environment: Tomcat 5.5.1
> Windows
> Eclipse + wtp
> Reporter: Thomas Mäder
> Assignee: Matej Knopp
> Priority: Minor
> Fix For: 1.3.0-beta4
>
> Attachments: TestModal.zip
>
>
> ModalWindow.onBeforeRender contains the following code:
> super.onBeforeRender();
> getContent().setOutputMarkupId(true);
> getContent().setVisible(shown);
> This has the consequence that the content of the modal windows is still invisible when its onBeforeRender() method is called. The default implementation of onBeforeRender delegates to the window's children beforeRender() method. However, the contents beforeRender() method first checks if the component is visible, which is not the case, so the onBeforeRender() call is not propagated down the component tree.
> This is a problem if the content of the modal window is something like a table, which populates itself in the onBeforeRender call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.