You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by vanta <gi...@git.apache.org> on 2015/08/21 11:26:44 UTC
[GitHub] commons-lang pull request: LANG-781 Added methods to ObjectUtils c...
GitHub user vanta opened a pull request:
https://github.com/apache/commons-lang/pull/108
LANG-781 Added methods to ObjectUtils class to check for null element…
I've created this pull request to refresh the issue LANG-781 as I faced a lack of methods to check nulls in array.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vanta/commons-lang master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/108.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #108
----
commit b9dfcfd1a18b2d277402084be0bd10faf0cabca4
Author: Krzysztof Wolny <k....@samrtrecruiters.com>
Date: 2015-07-28T12:54:19Z
LANG-781 Added methods to ObjectUtils class to check for null elements in the array
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: LANG-781 Added methods to ObjectUtils c...
Posted by vanta <gi...@git.apache.org>.
Github user vanta commented on the pull request:
https://github.com/apache/commons-lang/pull/108#issuecomment-159023629
Any update on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: LANG-781 Added methods to ObjectUtils c...
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the pull request:
https://github.com/apache/commons-lang/pull/108#issuecomment-219860202
There is a discussion going on right now on the dev mailing list about for-each vs. for. Let's see how that plays out. See https://commons.apache.org/mail-lists.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: LANG-781 Added methods to ObjectUtils c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/108
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: LANG-781 Added methods to ObjectUtils c...
Posted by vanta <gi...@git.apache.org>.
Github user vanta commented on the pull request:
https://github.com/apache/commons-lang/pull/108#issuecomment-221998592
@PascalSchumacher Nothing to sorry for :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: LANG-781 Added methods to ObjectUtils c...
Posted by vanta <gi...@git.apache.org>.
Github user vanta commented on the pull request:
https://github.com/apache/commons-lang/pull/108#issuecomment-219846549
@garydgregory How bout `firstNonNull` method that exists since 2009 and uses for-each loop to iterate over array?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: LANG-781 Added methods to ObjectUtils c...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/commons-lang/pull/108#issuecomment-221952053
Thanks! :+1:
For each loop won the discussion, so I merged only the first commit.
@vanta Sorry for telling you to refactor to use a for loop.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: LANG-781 Added methods to ObjectUtils c...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/commons-lang/pull/108#issuecomment-217712963
@vanta It would be nice if you could update the pull request according to garys comments.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: LANG-781 Added methods to ObjectUtils c...
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the pull request:
https://github.com/apache/commons-lang/pull/108#issuecomment-209650500
Yes:
- Thank you for the patch.
- The Javadoc has some bogus text, like starting with "<p></p>". You do not need that.
- Do not use a for-each loop to traverse an array. This creates an iterator when none is needed. Use a normal for loop, which will not create the extra Iterator to GC. This matters when a libraries is used on the critical path and/or environments trying to do low/no GC.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: LANG-781 Added methods to ObjectUtils c...
Posted by vanta <gi...@git.apache.org>.
Github user vanta commented on the pull request:
https://github.com/apache/commons-lang/pull/108#issuecomment-210151159
Thank you for response. I will apply changes you mentioned.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---