You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/29 20:40:58 UTC
Review Request 65408: Windows: Ported `slave_recovery_tests.cpp`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65408/
-----------------------------------------------------------
Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.
Bugs: MESOS-6713
https://issues.apache.org/jira/browse/MESOS-6713
Repository: mesos
Description
-------
This commit enables the unit tests found in `slave_recovery_tests.cpp`
to test agent recovery on Windows.
Diffs
-----
src/tests/CMakeLists.txt 6f1c67a6b4003ada1a0635a68fb7471895a2a6f5
src/tests/slave_recovery_tests.cpp 6dcbedb94a2c7b3d65770fc89920c0cad1298d1f
Diff: https://reviews.apache.org/r/65408/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 65408: Windows: Ported `slave_recovery_tests.cpp`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65408/#review196956
-----------------------------------------------------------
Ship it!
Couple of comment tweaks for you to do before committing.
src/tests/slave_recovery_tests.cpp
Lines 3258 (patched)
<https://reviews.apache.org/r/65408/#comment276944>
s/no/not/
src/tests/slave_recovery_tests.cpp
Lines 4449 (patched)
<https://reviews.apache.org/r/65408/#comment276945>
We stopped putting the extra `!` in this `#endif`s a while ago.
(There are only a few places left which haven't been cleaned up yet).
src/tests/slave_recovery_tests.cpp
Lines 4496 (patched)
<https://reviews.apache.org/r/65408/#comment276946>
Ditto about the `!`.
src/tests/slave_recovery_tests.cpp
Lines 4729-4730 (patched)
<https://reviews.apache.org/r/65408/#comment276947>
s/default Windows memory/default Windows isolators/
- Joseph Wu
On Feb. 1, 2018, 4:14 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65408/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2018, 4:14 p.m.)
>
>
> Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-6713
> https://issues.apache.org/jira/browse/MESOS-6713
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit enables the unit tests found in `slave_recovery_tests.cpp`
> to test agent recovery on Windows.
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt 6f1c67a6b4003ada1a0635a68fb7471895a2a6f5
> src/tests/slave_recovery_tests.cpp 77aa60c953bd0769eaba05f001755e4cec9ba028
>
>
> Diff: https://reviews.apache.org/r/65408/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 65408: Windows: Ported `slave_recovery_tests.cpp`.
Posted by Akash Gupta <ak...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65408/#review197043
-----------------------------------------------------------
Ship it!
Ship It!
- Akash Gupta
On Feb. 2, 2018, 12:14 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65408/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2018, 12:14 a.m.)
>
>
> Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-6713
> https://issues.apache.org/jira/browse/MESOS-6713
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit enables the unit tests found in `slave_recovery_tests.cpp`
> to test agent recovery on Windows.
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt 6f1c67a6b4003ada1a0635a68fb7471895a2a6f5
> src/tests/slave_recovery_tests.cpp 77aa60c953bd0769eaba05f001755e4cec9ba028
>
>
> Diff: https://reviews.apache.org/r/65408/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 65408: Windows: Ported `slave_recovery_tests.cpp`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65408/
-----------------------------------------------------------
(Updated Feb. 8, 2018, 11:53 a.m.)
Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.
Bugs: MESOS-6713
https://issues.apache.org/jira/browse/MESOS-6713
Repository: mesos
Description
-------
This commit enables the unit tests found in `slave_recovery_tests.cpp`
to test agent recovery on Windows.
Diffs (updated)
-----
src/tests/CMakeLists.txt 6f1c67a6b4003ada1a0635a68fb7471895a2a6f5
src/tests/slave_recovery_tests.cpp 77aa60c953bd0769eaba05f001755e4cec9ba028
Diff: https://reviews.apache.org/r/65408/diff/3/
Changes: https://reviews.apache.org/r/65408/diff/2-3/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 65408: Windows: Ported `slave_recovery_tests.cpp`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65408/
-----------------------------------------------------------
(Updated Feb. 1, 2018, 4:14 p.m.)
Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.
Changes
-------
Rebased.
Bugs: MESOS-6713
https://issues.apache.org/jira/browse/MESOS-6713
Repository: mesos
Description
-------
This commit enables the unit tests found in `slave_recovery_tests.cpp`
to test agent recovery on Windows.
Diffs (updated)
-----
src/tests/CMakeLists.txt 6f1c67a6b4003ada1a0635a68fb7471895a2a6f5
src/tests/slave_recovery_tests.cpp 77aa60c953bd0769eaba05f001755e4cec9ba028
Diff: https://reviews.apache.org/r/65408/diff/2/
Changes: https://reviews.apache.org/r/65408/diff/1-2/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 65408: Windows: Ported `slave_recovery_tests.cpp`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On Jan. 29, 2018, 1:28 p.m., Mesos Reviewbot Windows wrote:
> > FAIL: Some of the unit tests failed. Please check the relevant logs.
> >
> > Reviews applied: `['65397', '65398', '65399', '65400', '65401', '65402', '65403', '65404', '65405', '65406', '65407', '65408']`
> >
> > Failed command: `Start-MesosCITesting`
> >
> > All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65408
> >
> > Relevant logs:
> >
> > - [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65408/logs/mesos-tests-stdout.log):
> >
> > ```
> > [ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (104 ms)
> > [----------] 9 tests from Endpoint/SlaveEndpointTest (956 ms total)
> >
> > [----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
> > [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
> > [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (31 ms)
> > [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
> > [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (37 ms)
> > [----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (70 ms total)
> >
> > [----------] 1 test from IsolationFlag/CpuIsolatorTest
> > [ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
> > [ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2464 ms)
> > [----------] 1 test from IsolationFlag/CpuIsolatorTest (2489 ms total)
> >
> > [----------] 1 test from IsolationFlag/MemoryIsolatorTest
> > [ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
> > [ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2371 ms)
> > [----------] 1 test from IsolationFlag/MemoryIsolatorTest (2396 ms total)
> >
> > [----------] Global test environment tear-down
> > [==========] 891 tests from 88 test cases ran. (418002 ms total)
> > [ PASSED ] 890 tests.
> > [ FAILED ] 1 test, listed below:
> > [ FAILED ] SlaveRecoveryTest/0.ReconcileTasksMissingFromSlave, where TypeParam = class mesos::internal::slave::MesosContainerizer
> >
> > 1 FAILED TEST
> > YOU HAVE 211 DISABLED TESTS
> >
> > ```
> >
> > - [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65408/logs/mesos-tests-stderr.log):
> >
> > ```
> > I0129 21:28:37.657778 2528 executor.cpp:174] Received SUBSCRIBED event
> > I0129 21:28:37.657778 2528 executor.cpp:178] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
> > I0129 21:28:37.657778 2528 executor.cpp:174] Received LAUNCH event
> > I0129 21:28:37.667769 2528 executor.cpp:646] Starting task 7e622b9c-78fd-4508-bd58-9048bd7ea7c8
> > I0129 21:28:37.739790 2528 executor.cpp:481] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
> > I0129 21:28:38.277617 2528 executor.cpp:659] Forked command at 6192
> > I0129 21:28:38.303606 3108 exec.cpp:445] Executor asked to shutdown
> > I0129 21:28:38.304605 7948 executor.cpp:174] Received SHUTDOWN event
> > I0129 21:28:38.304605 7948 executor.cpp:756] Shutting down
> > I0129 21:28:38.304605 7948 executor.cpp:871] Sending SIGTERM to process tree at pid 6ng framework 4a018398-6261-4c24-ac36-f77ebe8866ca-0000 (default) at scheduler-200376e4-e6e6-4262-a4c5-6f6a00f41a06@10.3.1.5:55668
> > I0129 21:28:38.301606 8564 hierarchical.cpp:405] Deactivated framework 4a018398-6261-4c24-ac36-f77ebe8866ca-0000
> > I0129 21:28:38.301606 7336 master.cpp:10210] Updating the state of task 7e622b9c-78fd-4508-bd58-9048bd7ea7c8 of framework 4a018398-6261-4c24-ac36-f77ebe8866ca-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
> > I0129 21:28:38.302613 9636 slave.cpp:3479] Shutting down framework 4a018398-6261-4c24-ac36-f77ebe8866ca-0000
> > I0129 21:28:38.302613 9636 slave.cpp:6178] Shutting down executor '7e622b9c-78fd-4508-bd58-9048bd7ea7c8' of framework 4a018398-6261-4c24-ac36-f77ebe8866ca-0000 at executor(1)@10.3.1.5:55689
> > I0129 21:28:38.302613 9636 slave.cpp:931] Agent terminating
> > W0129 21:28:38.303606 9636 slave.cpp:3475] Ignoring shutdown framework 4a018398-6261-4c24-ac36-f77ebe8866ca-0000 because it is terminating
> > I0129 21:28:38.304605 7336 master.cpp:10309] Removing task 7e622b9c-78fd-4508-bd58-9048bd7ea7c8 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 4a018398-6261-4c24-ac36-f77ebe8866ca-0000 on agent 4a018398-6261-4c24-ac36-f77ebe8866ca-S0 at slave(398)@10.3.1.5:55668 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
> > I0129 21:28:38.305605 9636 containerizer.cpp:2338] Destroying container fba1f53a-949e-4d66-b808-ddd4cb73b6ba in RUNNING state
> > I0129 21:28:38.306605 9636 containerizer.cpp:2952] Transitioning the state of container fba1f53a-949e-4d66-b808-ddd4cb73b6ba from RUNNING to DESTROYING
> > I0129 21:28:38.306605 9636 launcher.cpp:156] Asked to destroy container fba1f53a-949e-4d66-b808-ddd4cb73b6ba
> > I0129 21:28:38.307605 7336 master.cpp:1307] Agent 4a018398-6261-4c24-ac36-f77ebe8866ca-S0 at slave(398)@10.3.1.5:55668 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
> > I0129 21:28:38.307605 7336 master.cpp:3288] Disconnecting agent 4a018398-6261-4c24-ac36-f77ebe8866ca-S0 at slave(398)@10.3.1.5:55668 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
> > I0129 21:28:38.307605 8560 hierarchical.cpp:344] Removed framework 4a018398-6261-4c24-ac36-f77ebe8866ca-0000
> > I0129 21:28:38.307605 7336 master.cpp:3307] Deactivating agent 4a018398-6261-4c24-ac36-f77ebe8866ca-S0 at slave(398)@10.3.1.5:55668 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
> > I0129 21:28:38.308604 9412 hierarchical.cpp:766] Agent 4a018398-6261-4c24-ac36-f77ebe8866ca-S0 deactivated
> > I0129 21:28:38.384750 8560 containerizer.cpp:2791] Container fba1f53a-949e-4d66-b808-ddd4cb73b6ba has exited
> > I0129 21:28:38.414060 9020 master.cpp:1149] Master terminating
> > I0129 21:28:38.417027 9412 hierarchical.cpp:609] Removed agent 4a018398-6261-4c24-ac36-f77ebe8866ca-S0
> > I0129 21:28:38.782963 2936 process.cpp:928] Stopped the socket accept loop
> > ```
Woo, this test was already fixed in the next patch.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65408/#review196470
-----------------------------------------------------------
On Jan. 29, 2018, 12:40 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65408/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2018, 12:40 p.m.)
>
>
> Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-6713
> https://issues.apache.org/jira/browse/MESOS-6713
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit enables the unit tests found in `slave_recovery_tests.cpp`
> to test agent recovery on Windows.
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt 6f1c67a6b4003ada1a0635a68fb7471895a2a6f5
> src/tests/slave_recovery_tests.cpp 6dcbedb94a2c7b3d65770fc89920c0cad1298d1f
>
>
> Diff: https://reviews.apache.org/r/65408/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 65408: Windows: Ported `slave_recovery_tests.cpp`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65408/#review196470
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['65397', '65398', '65399', '65400', '65401', '65402', '65403', '65404', '65405', '65406', '65407', '65408']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65408
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65408/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (104 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (956 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (31 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (37 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (70 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2464 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2489 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2371 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2396 ms total)
[----------] Global test environment tear-down
[==========] 891 tests from 88 test cases ran. (418002 ms total)
[ PASSED ] 890 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] SlaveRecoveryTest/0.ReconcileTasksMissingFromSlave, where TypeParam = class mesos::internal::slave::MesosContainerizer
1 FAILED TEST
YOU HAVE 211 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65408/logs/mesos-tests-stderr.log):
```
I0129 21:28:37.657778 2528 executor.cpp:174] Received SUBSCRIBED event
I0129 21:28:37.657778 2528 executor.cpp:178] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0129 21:28:37.657778 2528 executor.cpp:174] Received LAUNCH event
I0129 21:28:37.667769 2528 executor.cpp:646] Starting task 7e622b9c-78fd-4508-bd58-9048bd7ea7c8
I0129 21:28:37.739790 2528 executor.cpp:481] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0129 21:28:38.277617 2528 executor.cpp:659] Forked command at 6192
I0129 21:28:38.303606 3108 exec.cpp:445] Executor asked to shutdown
I0129 21:28:38.304605 7948 executor.cpp:174] Received SHUTDOWN event
I0129 21:28:38.304605 7948 executor.cpp:756] Shutting down
I0129 21:28:38.304605 7948 executor.cpp:871] Sending SIGTERM to process tree at pid 6ng framework 4a018398-6261-4c24-ac36-f77ebe8866ca-0000 (default) at scheduler-200376e4-e6e6-4262-a4c5-6f6a00f41a06@10.3.1.5:55668
I0129 21:28:38.301606 8564 hierarchical.cpp:405] Deactivated framework 4a018398-6261-4c24-ac36-f77ebe8866ca-0000
I0129 21:28:38.301606 7336 master.cpp:10210] Updating the state of task 7e622b9c-78fd-4508-bd58-9048bd7ea7c8 of framework 4a018398-6261-4c24-ac36-f77ebe8866ca-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0129 21:28:38.302613 9636 slave.cpp:3479] Shutting down framework 4a018398-6261-4c24-ac36-f77ebe8866ca-0000
I0129 21:28:38.302613 9636 slave.cpp:6178] Shutting down executor '7e622b9c-78fd-4508-bd58-9048bd7ea7c8' of framework 4a018398-6261-4c24-ac36-f77ebe8866ca-0000 at executor(1)@10.3.1.5:55689
I0129 21:28:38.302613 9636 slave.cpp:931] Agent terminating
W0129 21:28:38.303606 9636 slave.cpp:3475] Ignoring shutdown framework 4a018398-6261-4c24-ac36-f77ebe8866ca-0000 because it is terminating
I0129 21:28:38.304605 7336 master.cpp:10309] Removing task 7e622b9c-78fd-4508-bd58-9048bd7ea7c8 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 4a018398-6261-4c24-ac36-f77ebe8866ca-0000 on agent 4a018398-6261-4c24-ac36-f77ebe8866ca-S0 at slave(398)@10.3.1.5:55668 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0129 21:28:38.305605 9636 containerizer.cpp:2338] Destroying container fba1f53a-949e-4d66-b808-ddd4cb73b6ba in RUNNING state
I0129 21:28:38.306605 9636 containerizer.cpp:2952] Transitioning the state of container fba1f53a-949e-4d66-b808-ddd4cb73b6ba from RUNNING to DESTROYING
I0129 21:28:38.306605 9636 launcher.cpp:156] Asked to destroy container fba1f53a-949e-4d66-b808-ddd4cb73b6ba
I0129 21:28:38.307605 7336 master.cpp:1307] Agent 4a018398-6261-4c24-ac36-f77ebe8866ca-S0 at slave(398)@10.3.1.5:55668 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0129 21:28:38.307605 7336 master.cpp:3288] Disconnecting agent 4a018398-6261-4c24-ac36-f77ebe8866ca-S0 at slave(398)@10.3.1.5:55668 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0129 21:28:38.307605 8560 hierarchical.cpp:344] Removed framework 4a018398-6261-4c24-ac36-f77ebe8866ca-0000
I0129 21:28:38.307605 7336 master.cpp:3307] Deactivating agent 4a018398-6261-4c24-ac36-f77ebe8866ca-S0 at slave(398)@10.3.1.5:55668 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0129 21:28:38.308604 9412 hierarchical.cpp:766] Agent 4a018398-6261-4c24-ac36-f77ebe8866ca-S0 deactivated
I0129 21:28:38.384750 8560 containerizer.cpp:2791] Container fba1f53a-949e-4d66-b808-ddd4cb73b6ba has exited
I0129 21:28:38.414060 9020 master.cpp:1149] Master terminating
I0129 21:28:38.417027 9412 hierarchical.cpp:609] Removed agent 4a018398-6261-4c24-ac36-f77ebe8866ca-S0
I0129 21:28:38.782963 2936 process.cpp:928] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Jan. 29, 2018, 8:40 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65408/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2018, 8:40 p.m.)
>
>
> Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-6713
> https://issues.apache.org/jira/browse/MESOS-6713
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit enables the unit tests found in `slave_recovery_tests.cpp`
> to test agent recovery on Windows.
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt 6f1c67a6b4003ada1a0635a68fb7471895a2a6f5
> src/tests/slave_recovery_tests.cpp 6dcbedb94a2c7b3d65770fc89920c0cad1298d1f
>
>
> Diff: https://reviews.apache.org/r/65408/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>