You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/12/05 14:48:26 UTC
[GitHub] [inlong] ZuoFengZhang opened a new pull request, #6753: [INLONG-6734][Manager] The Row_CSV data-type is not an inlong component
ZuoFengZhang opened a new pull request, #6753:
URL: https://github.com/apache/inlong/pull/6753
### Prepare a Pull Request
- The `Raw_CSV` data-type is not an inlong component
- Fixes #6734
### Motivation
When `Raw-CSV` DataType is selected in DataStream, the message is not packed with `Inlong-msg`, but separated by a specific delimiter.
When create the `ExtractNode`:
`org.apache.inlong.manager.pojo.sort.util.ExtractNodeUtils#createExtractNode(org.apache.inlong.manager.pojo.source.pulsar.PulsarSource)`
```java
if (pulsarSource.isInlongComponent()) {
Format innerFormat = format;
format = new InLongMsgFormat(innerFormat, false);
}
```
> The field `isInlongComponent` indicates whether to use inlong-message packaging.
But, `getSourceMap` in `org.apache.inlong.manager.service.source.pulsar.PulsarSourceOperator`, fixed written as:
```java
pulsarSource.setInlongComponent(true);
```
### Modifications
According to the value of datatype, when using RAW_CSV format, not an inlong component,
marked as not inlong-component.
### Verifying this change
*(Please pick either of the following options)*
- [x] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] ZuoFengZhang commented on a diff in pull request #6753: [INLONG-6734][Manager] The Raw_CSV data-type marked as not an inlong component
Posted by GitBox <gi...@apache.org>.
ZuoFengZhang commented on code in PR #6753:
URL: https://github.com/apache/inlong/pull/6753#discussion_r1040988325
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/pulsar/PulsarSourceOperator.java:
##########
@@ -126,7 +126,12 @@ public Map<String, List<StreamSource>> getSourcesMap(InlongGroupInfo groupInfo,
pulsarSource.setTopic(streamInfo.getMqResource());
pulsarSource.setAdminUrl(adminUrl);
pulsarSource.setServiceUrl(serviceUrl);
- pulsarSource.setInlongComponent(true);
+
+ // CSV: InLong message type whose message body is raw CSV
+ // Raw-CSV: messages are separated by a specific separator
+ // When using RAW_CSV format, not an inlong component
+ boolean isInlongComponent = !"RAW_CSV".equals(streamInfo.getDataType());
Review Comment:
Done, I have modified it in the second commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #6753: [INLONG-6734][Manager] The Raw_CSV data-type marked as not an inlong component
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6753:
URL: https://github.com/apache/inlong/pull/6753#discussion_r1041682114
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/pulsar/PulsarSourceOperator.java:
##########
@@ -126,7 +128,12 @@ public Map<String, List<StreamSource>> getSourcesMap(InlongGroupInfo groupInfo,
pulsarSource.setTopic(streamInfo.getMqResource());
pulsarSource.setAdminUrl(adminUrl);
pulsarSource.setServiceUrl(serviceUrl);
- pulsarSource.setInlongComponent(true);
+
+ // CSV: InLong message type whose message body is raw CSV
Review Comment:
This logic is strange. Can other types not be InLong components?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow merged pull request #6753: [INLONG-6734][Manager] Support non-InlongMessage format of Kafka and Pulsar
Posted by GitBox <gi...@apache.org>.
healchow merged PR #6753:
URL: https://github.com/apache/inlong/pull/6753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] fuweng11 commented on a diff in pull request #6753: [INLONG-6734][Manager] The Raw_CSV data-type marked as not an inlong component
Posted by GitBox <gi...@apache.org>.
fuweng11 commented on code in PR #6753:
URL: https://github.com/apache/inlong/pull/6753#discussion_r1040976160
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/pulsar/PulsarSourceOperator.java:
##########
@@ -126,7 +126,12 @@ public Map<String, List<StreamSource>> getSourcesMap(InlongGroupInfo groupInfo,
pulsarSource.setTopic(streamInfo.getMqResource());
pulsarSource.setAdminUrl(adminUrl);
pulsarSource.setServiceUrl(serviceUrl);
- pulsarSource.setInlongComponent(true);
+
+ // CSV: InLong message type whose message body is raw CSV
+ // Raw-CSV: messages are separated by a specific separator
+ // When using RAW_CSV format, not an inlong component
+ boolean isInlongComponent = !"RAW_CSV".equals(streamInfo.getDataType());
Review Comment:
It is recommended to move constants to `InlongConstants`, like `InlongConstants.DATA_TYPE_RAW_CSV`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] ZuoFengZhang closed pull request #6753: [INLONG-6734][Manager] The Raw_CSV data-type marked as not an inlong component
Posted by GitBox <gi...@apache.org>.
ZuoFengZhang closed pull request #6753: [INLONG-6734][Manager] The Raw_CSV data-type marked as not an inlong component
URL: https://github.com/apache/inlong/pull/6753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #6753: [INLONG-6734][Manager] Support non-InlongMessage format of Kafka and Pulsar
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6753:
URL: https://github.com/apache/inlong/pull/6753#discussion_r1042309796
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/source/kafka/KafkaSource.java:
##########
@@ -90,6 +90,8 @@ public class KafkaSource extends StreamSource {
@ApiModelProperty(value = "Data field escape symbol")
private String dataEscapeChar;
+ @ApiModelProperty("Whether wrap content with InlongMessage")
+ private boolean wrapWithInlongMessage = true;
Review Comment:
1. Add one blank line before the new field.
2. Suggest changing the field name to `wrapWithInlongMsg`, because `InlongMsg` is the same as the `InLongMsgXxx`.
```suggestion
@ApiModelProperty("Whether wrap content with InlongMsg")
private boolean wrapWithInlongMsg = true;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org