You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/25 13:52:52 UTC

[GitHub] [shardingsphere] sluk3r opened a new pull request #7613: ShardingSelectStatementValidator extracted

sluk3r opened a new pull request #7613:
URL: https://github.com/apache/shardingsphere/pull/7613


   for  #7531.
   
   Changes proposed in this pull request:
   - ShardingSelectStatementValidator added to contain validation logic that origines in ShardingRouteDecorator
   - ShardingRouteDecoratorTest added
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu closed pull request #7613: ShardingSelectStatementValidator extracted

Posted by GitBox <gi...@apache.org>.
terrymanu closed pull request #7613:
URL: https://github.com/apache/shardingsphere/pull/7613


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #7613: ShardingSelectStatementValidator extracted

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #7613:
URL: https://github.com/apache/shardingsphere/pull/7613#issuecomment-706476517


   Hi @sluk3r Friendly ping.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on pull request #7613: ShardingSelectStatementValidator extracted

Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #7613:
URL: https://github.com/apache/shardingsphere/pull/7613#issuecomment-707823150


   Will close soon if no update anymore


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sluk3r commented on pull request #7613: ShardingSelectStatementValidator extracted

Posted by GitBox <gi...@apache.org>.
sluk3r commented on pull request #7613:
URL: https://github.com/apache/shardingsphere/pull/7613#issuecomment-706493591


   > Hi @sluk3r Friendly ping.
   
   Hi
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #7613: ShardingSelectStatementValidator extracted

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #7613:
URL: https://github.com/apache/shardingsphere/pull/7613#issuecomment-706503425


   @sluk3r As this PR has remained CI failed for a long time, ICYMI, I brought it to your attention. Take it easy, follow your schedule to do it. :) 
   BTW, If you need any help or have something blocked, I think @strongduanmu will provide helpful suggestions. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero edited a comment on pull request #7613: ShardingSelectStatementValidator extracted

Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on pull request #7613:
URL: https://github.com/apache/shardingsphere/pull/7613#issuecomment-706503425


   @sluk3r As this PR has remained CI failed for a long time, ICYMI, I brought it to your attention. Take it easy, follow your schedule to do it. :) 
   BTW, If you need any help or have something blocked, I think @strongduanmu would provide helpful suggestions. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org