You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2019/11/07 16:54:22 UTC

[GitHub] [samza] gauravrkulkarni commented on a change in pull request #1214: SAMZA-2375, SAMZA-2376: Add display name to UdfMetadata and handle trailing semi-colons

gauravrkulkarni commented on a change in pull request #1214: SAMZA-2375, SAMZA-2376: Add display name to UdfMetadata and handle trailing semi-colons
URL: https://github.com/apache/samza/pull/1214#discussion_r343760801
 
 

 ##########
 File path: samza-sql/src/main/java/org/apache/samza/sql/interfaces/UdfMetadata.java
 ##########
 @@ -32,6 +32,7 @@
 public class UdfMetadata {
 
   private final String name;
+  private final String displayName;
 
 Review comment:
   Might want to add a comment/example explaining the difference between name and displayName (if this isn't a well know samza concept)? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services