You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ah...@apache.org on 2013/06/14 10:11:30 UTC
[04/10] git commit: Code cleanup - It's better (for perfs) to use a
chain of append() calls than a unique append with several Strings
concatenations
Code cleanup - It's better (for perfs) to use a chain of append() calls than a unique append with several Strings concatenations
Project: http://git-wip-us.apache.org/repos/asf/maven/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/c8e94a5b
Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/c8e94a5b
Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/c8e94a5b
Branch: refs/heads/master
Commit: c8e94a5b085b1cb1543861d40db7a7a108bef499
Parents: c747fbe
Author: Arnaud Héritier <ah...@apache.org>
Authored: Tue Jun 11 21:58:50 2013 +0200
Committer: Arnaud Héritier <ah...@apache.org>
Committed: Tue Jun 11 21:58:50 2013 +0200
----------------------------------------------------------------------
.../AbstractArtifactResolutionException.java | 5 +++--
.../project/validation/ModelValidationResult.java | 3 ++-
.../repository/metadata/ClasspathContainer.java | 4 ++--
.../maven/repository/metadata/MetadataGraph.java | 6 +++---
.../repository/metadata/MetadataGraphVertex.java | 8 ++++----
.../maven/plugin/PluginParameterException.java | 4 ++--
.../java/org/apache/maven/cli/CLIReportingUtils.java | 15 ++++++++-------
.../java/org/apache/maven/cli/CLIManagerTest.java | 2 +-
8 files changed, 25 insertions(+), 22 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/maven/blob/c8e94a5b/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/AbstractArtifactResolutionException.java
----------------------------------------------------------------------
diff --git a/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/AbstractArtifactResolutionException.java b/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/AbstractArtifactResolutionException.java
index 9cfc36b..393e028 100644
--- a/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/AbstractArtifactResolutionException.java
+++ b/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/AbstractArtifactResolutionException.java
@@ -199,13 +199,14 @@ public class AbstractArtifactResolutionException
if ( message == null || !message.contains( "from the specified remote repositories:" ) )
{
sb.append( LS );
- sb.append( " " + groupId + ":" + artifactId + ":" + type + ":" + version );
+ sb.append( " " ).append( groupId ).append( ":" ).append( artifactId ).append( ":" ).append( type ).append(
+ ":" ).append( version );
sb.append( LS );
if ( remoteRepositories != null )
{
sb.append( LS );
sb.append( "from the specified remote repositories:" );
- sb.append( LS + " " );
+ sb.append( LS ).append( " " );
if ( remoteRepositories.isEmpty() )
{
http://git-wip-us.apache.org/repos/asf/maven/blob/c8e94a5b/maven-compat/src/main/java/org/apache/maven/project/validation/ModelValidationResult.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/project/validation/ModelValidationResult.java b/maven-compat/src/main/java/org/apache/maven/project/validation/ModelValidationResult.java
index 12ead7e..cb8c601 100644
--- a/maven-compat/src/main/java/org/apache/maven/project/validation/ModelValidationResult.java
+++ b/maven-compat/src/main/java/org/apache/maven/project/validation/ModelValidationResult.java
@@ -85,7 +85,8 @@ public class ModelValidationResult
//
for ( int i = 0; i < messages.size(); i++ )
{
- message.append( indentation + "[" + i + "] " + messages.get( i ) + NEWLINE );
+ message.append( indentation ).append( "[" ).append( i ).append( "] " ).append( messages.get( i ) ).append(
+ NEWLINE );
}
return message.toString();
http://git-wip-us.apache.org/repos/asf/maven/blob/c8e94a5b/maven-compat/src/main/java/org/apache/maven/repository/metadata/ClasspathContainer.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/repository/metadata/ClasspathContainer.java b/maven-compat/src/main/java/org/apache/maven/repository/metadata/ClasspathContainer.java
index 593daac..cdf28f6 100644
--- a/maven-compat/src/main/java/org/apache/maven/repository/metadata/ClasspathContainer.java
+++ b/maven-compat/src/main/java/org/apache/maven/repository/metadata/ClasspathContainer.java
@@ -129,12 +129,12 @@ implements Iterable<ArtifactMetadata>
public String toString()
{
StringBuilder sb = new StringBuilder( 256 );
- sb.append( "[scope=" + scope.getScope() );
+ sb.append( "[scope=" ).append( scope.getScope() );
if ( classpath != null )
{
for ( ArtifactMetadata md : classpath )
{
- sb.append( ": " + md.toString() + '{' + md.getArtifactUri() + '}' );
+ sb.append( ": " ).append( md.toString() ).append( '{' ).append( md.getArtifactUri() ).append( '}' );
}
}
sb.append( ']' );
http://git-wip-us.apache.org/repos/asf/maven/blob/c8e94a5b/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraph.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraph.java b/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraph.java
index b116c69..55b0250 100644
--- a/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraph.java
+++ b/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraph.java
@@ -485,13 +485,13 @@ public class MetadataGraph
}
for ( MetadataGraphVertex v : vertices )
{
- sb.append( "Vertex: " + v.getMd().toString() + "\n" );
+ sb.append( "Vertex: " ).append( v.getMd().toString() ).append( "\n" );
List<MetadataGraphEdge> ins = getIncidentEdges( v );
if ( ins != null )
{
for ( MetadataGraphEdge e : ins )
{
- sb.append( " from : " + e.toString() + "\n" );
+ sb.append( " from : " ).append( e.toString() ).append( "\n" );
}
}
else
@@ -504,7 +504,7 @@ public class MetadataGraph
{
for ( MetadataGraphEdge e : outs )
{
- sb.append( " to : " + e.toString() + "\n" );
+ sb.append( " to : " ).append( e.toString() ).append( "\n" );
}
}
else
http://git-wip-us.apache.org/repos/asf/maven/blob/c8e94a5b/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraphVertex.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraphVertex.java b/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraphVertex.java
index 87ff70b..202a01f 100644
--- a/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraphVertex.java
+++ b/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraphVertex.java
@@ -192,17 +192,17 @@ public class MetadataGraphVertex
return super.hashCode();
}
StringBuilder hashString = new StringBuilder( 128 );
- hashString.append( md.groupId + "|" );
- hashString.append( md.artifactId + "|" );
+ hashString.append( md.groupId ).append( "|" );
+ hashString.append( md.artifactId ).append( "|" );
if ( compareVersion )
{
- hashString.append( md.version + "|" );
+ hashString.append( md.version ).append( "|" );
}
if ( compareScope )
{
- hashString.append( md.getArtifactScope() + "|" );
+ hashString.append( md.getArtifactScope() ).append( "|" );
}
return hashString.toString().hashCode();
http://git-wip-us.apache.org/repos/asf/maven/blob/c8e94a5b/maven-core/src/main/java/org/apache/maven/plugin/PluginParameterException.java
----------------------------------------------------------------------
diff --git a/maven-core/src/main/java/org/apache/maven/plugin/PluginParameterException.java b/maven-core/src/main/java/org/apache/maven/plugin/PluginParameterException.java
index f14bfc0..dfdd432 100644
--- a/maven-core/src/main/java/org/apache/maven/plugin/PluginParameterException.java
+++ b/maven-core/src/main/java/org/apache/maven/plugin/PluginParameterException.java
@@ -144,8 +144,8 @@ public class PluginParameterException
String alias = param.getAlias();
if ( StringUtils.isNotEmpty( alias ) && !alias.equals( param.getName() ) )
{
- messageBuffer.append(
- "\n\n-OR-\n\n<configuration>\n ...\n <" + alias + ">VALUE</" + alias + ">\n</configuration>\n" );
+ messageBuffer.append( "\n\n-OR-\n\n<configuration>\n ...\n <" ).append( alias ).append(
+ ">VALUE</" ).append( alias ).append( ">\n</configuration>\n" );
}
}
http://git-wip-us.apache.org/repos/asf/maven/blob/c8e94a5b/maven-embedder/src/main/java/org/apache/maven/cli/CLIReportingUtils.java
----------------------------------------------------------------------
diff --git a/maven-embedder/src/main/java/org/apache/maven/cli/CLIReportingUtils.java b/maven-embedder/src/main/java/org/apache/maven/cli/CLIReportingUtils.java
index 0ed30dc..186f937 100644
--- a/maven-embedder/src/main/java/org/apache/maven/cli/CLIReportingUtils.java
+++ b/maven-embedder/src/main/java/org/apache/maven/cli/CLIReportingUtils.java
@@ -55,13 +55,14 @@ public final class CLIReportingUtils
version.append( createMavenVersionString( properties ) ).append( LS );
version.append( reduce( properties.getProperty( "distributionShortName" ) + " home: "
+ System.getProperty( "maven.home", "<unknown maven home>" ) ) ).append( LS );
- version.append( "Java version: " + System.getProperty( "java.version", "<unknown java version>" )
- + ", vendor: " + System.getProperty( "java.vendor", "<unknown vendor>" ) ).append( LS );
- version.append( "Java home: " + System.getProperty( "java.home", "<unknown java home>" ) ).append( LS );
- version.append( "Default locale: " + Locale.getDefault() + ", platform encoding: "
- + System.getProperty( "file.encoding", "<unknown encoding>" ) ).append( LS );
- version.append( "OS name: \"" + Os.OS_NAME + "\", version: \"" + Os.OS_VERSION + "\", arch: \"" + Os.OS_ARCH
- + "\", family: \"" + Os.OS_FAMILY + "\"" );
+ version.append( "Java version: " ).append(
+ System.getProperty( "java.version", "<unknown java version>" ) ).append( ", vendor: " ).append(
+ System.getProperty( "java.vendor", "<unknown vendor>" ) ).append( LS );
+ version.append( "Java home: " ).append( System.getProperty( "java.home", "<unknown java home>" ) ).append( LS );
+ version.append( "Default locale: " ).append( Locale.getDefault() ).append( ", platform encoding: " ).append(
+ System.getProperty( "file.encoding", "<unknown encoding>" ) ).append( LS );
+ version.append( "OS name: \"" ).append( Os.OS_NAME ).append( "\", version: \"" ).append( Os.OS_VERSION ).append(
+ "\", arch: \"" ).append( Os.OS_ARCH ).append( "\", family: \"" ).append( Os.OS_FAMILY ).append( "\"" );
return version.toString();
}
http://git-wip-us.apache.org/repos/asf/maven/blob/c8e94a5b/maven-embedder/src/test/java/org/apache/maven/cli/CLIManagerTest.java
----------------------------------------------------------------------
diff --git a/maven-embedder/src/test/java/org/apache/maven/cli/CLIManagerTest.java b/maven-embedder/src/test/java/org/apache/maven/cli/CLIManagerTest.java
index 716127b..9df1768 100644
--- a/maven-embedder/src/test/java/org/apache/maven/cli/CLIManagerTest.java
+++ b/maven-embedder/src/test/java/org/apache/maven/cli/CLIManagerTest.java
@@ -70,7 +70,7 @@ public class CLIManagerTest
for ( Option option : new CLIManagerExtension().getOptions() )
{
a = !a;
- sb.append( "<tr class='" + ( a ? 'a' : 'b' ) + "'><td><code>-<a name='" );
+ sb.append( "<tr class='" ).append( a ? 'a' : 'b' ).append( "'><td><code>-<a name='" );
sb.append( option.getOpt() );
sb.append( "'>" );
sb.append( option.getOpt() );