[jira] [Comment Edited] (INLONG-605) Refactor the INLONG configuration framework

["Roc Marshal (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/INLONG-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17343666#comment-17343666 ] 

Roc Marshal edited comment on INLONG-605 at 5/13/21, 3:03 AM:
--------------------------------------------------------------

Thanks you for your response [~gosonzhang] . I will specify the plan before coding, and then proceed to the next step after the community discussion and approval.
 Should I show the  plan on [https://cwiki.apache.org/confluence/display/TUBEMQ/TubeMQ+Improvement+Proposals] or  [https://cwiki.apache.org/confluence/display/Inlong/InLong+Improvement+Proposals] which does not exist now?


was (Author: rocmarshal):
Thanks you for your response. I will specify the plan before coding, and then proceed to the next step after the community discussion and approval.
Should me show the  plan on [https://cwiki.apache.org/confluence/display/TUBEMQ/TubeMQ+Improvement+Proposals] or  [https://cwiki.apache.org/confluence/display/Inlong/InLong+Improvement+Proposals] which does not exist now?

> Refactor the INLONG configuration framework
> -------------------------------------------
>
>                 Key: INLONG-605
>                 URL: https://issues.apache.org/jira/browse/INLONG-605
>             Project: Apache InLong
>          Issue Type: Improvement
>          Components: Broker, Client, Master, Server
>            Reporter: Roc Marshal
>            Assignee: Roc Marshal
>            Priority: Major
>              Labels: patch
>
> # Reconstruct it according to the [Flink configuration module|https://github.com/apache/flink/tree/master/flink-core/src/main/java/org/apache/flink/configuration] format to make improvements for codes quality, such as these core classes 
>  [ConfigConstants.java|https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java]
>  [ConfigOption.java|https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/ConfigOption.java]
>  [ConfigOptions.java|https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/ConfigOptions.java]
>  [Configuration.java|https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/Configuration.java]
>  etc.
>  # Classes that might need to be refactored:
>  [BrokerConfig.java|https://github.com/apache/incubator-inlong/blob/master/tubemq-server/src/main/java/org/apache/tubemq/server/broker/BrokerConfig.java] 
>  [AbstractFileConfig.java|https://github.com/apache/incubator-inlong/blob/master/tubemq-server/src/main/java/org/apache/tubemq/server/common/fileconfig/AbstractFileConfig.java]
>  [TLSConfig.java|https://github.com/apache/incubator-inlong/blob/master/tubemq-core/src/main/java/org/apache/tubemq/corebase/config/TLSConfig.java]
>  [TubeClientConfig.java|https://github.com/apache/incubator-inlong/blob/master/tubemq-client/src/main/java/org/apache/tubemq/client/config/TubeClientConfig.java]
>  [ConsumerConfig.java|https://github.com/apache/incubator-inlong/blob/master/tubemq-client/src/main/java/org/apache/tubemq/client/config/ConsumerConfig.java]
>  [TubeClientConfigUtils.java|https://github.com/apache/incubator-inlong/blob/master/tubemq-client/src/main/java/org/apache/tubemq/client/config/TubeClientConfigUtils.java]
>  [MasterReplicationConfig.java|http://https//github.com/apache/incubator-inlong/blob/master/tubemq-server/src/main/java/org/apache/tubemq/server/common/fileconfig/MasterReplicationConfig.java]
>  [RpcConfig.java|https://github.com/apache/incubator-inlong/blob/master/tubemq-core/src/main/java/org/apache/tubemq/corerpc/RpcConfig.java]
>  [RpcConstants.java|https://github.com/apache/incubator-inlong/blob/master/tubemq-core/src/main/java/org/apache/tubemq/corerpc/RpcConstants.java]
>  # Group these configuration items based on their component roles.Master,Broker,Client..



--
This message was sent by Atlassian Jira
(v8.3.4#803005)