[GitHub] ahshokry commented on a change in pull request #283: Adding Periodic Advertising Feature

[GitBox <gi...@apache.org>]

ahshokry commented on a change in pull request #283: Adding Periodic Advertising Feature
URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r260316678
 
 

 ##########
 File path: nimble/host/src/ble_gap.c
 ##########
 @@ -155,6 +163,10 @@ struct ble_gap_slave_state {
     unsigned int directed:1;
     unsigned int legacy_pdu:1;
     unsigned int rnd_addr_set:1;
+#if MYNEWT_VAL(BLE_PERIODIC_ADV)
+    unsigned int per_configured:1;
+    uint8_t       per_op;
 
 Review comment:
   Agree with the second part.
   As for the first part, we can have a configured periodic advertising instant (`periodic_configured = 1`), but the periodic advertising is not really enabled (`periodic_op = BLE_GAP_OP_NULL`)
   
   Also, as described before, periodic advertising doesn't require an extended advertising to be running all the time. This means that `op` may be `BLE_GAP_OP_NULL` or even `BLE_GAP_OP_M_DISC`, while we have a running periodic advertising instant

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services