You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/03 13:50:06 UTC

[GitHub] [arrow] romainfrancois commented on a change in pull request #11751: ARROW-14694: [R] Let me dput a schema

romainfrancois commented on a change in pull request #11751:
URL: https://github.com/apache/arrow/pull/11751#discussion_r761951904



##########
File path: r/R/dictionary.R
##########
@@ -34,6 +34,19 @@ DictionaryType <- R6Class("DictionaryType",
   public = list(
     ToString = function() {
       prettier_dictionary_type(DataType__ToString(self))
+    },
+    code = function() {

Review comment:
       it could as it's always called without arguments, but having `$code()` implies an action, i.e. making the code, instead of retrieving a property. 
   
   I don't mind changing though. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org