You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2022/04/05 04:55:48 UTC

[GitHub] [orc] guiyanakuang commented on pull request #1080: ORC-1147: Use `Objects.equals(dstas.getSum(), Double.NaN)` instead of `isFinite` to determine if there is a NaN write

guiyanakuang commented on PR #1080:
URL: https://github.com/apache/orc/pull/1080#issuecomment-1088267454

   > Oh, @guiyanakuang . This is not correct, @guiyanakuang .
   > 
   > There exists multiple NaN values. Double.NaN is just one of them.
   
   Maybe I should use the JDK's own method `new Double(dstas.getSum()).isNaN()`, where I want to exclude Double.POSITIVE_INFINITY / Double.NEGATIVE_INFINITY both cases, and only match NaN


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org