[GitHub] [incubator-superset] nytai commented on a change in pull request #8845: [WIP] new, Dashboard list view (react)

[GitBox <gi...@apache.org>]

nytai commented on a change in pull request #8845: [WIP] new, Dashboard list view (react)
URL: https://github.com/apache/incubator-superset/pull/8845#discussion_r360477018
 
 

 ##########
 File path: superset/assets/jest.config.js
 ##########
 @@ -32,4 +32,11 @@ module.exports = {
     '^.+\\.tsx?$': 'ts-jest',
   },
   moduleFileExtensions: ['ts', 'tsx', 'js', 'jsx', 'json'],
+  globals: {
+    'ts-jest': {
+      diagnostics: {
+        warnOnly: true,
 
 Review comment:
   so type errors don't cause jest tests to fail (they're still reported though) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org