You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by gesellix <gi...@git.apache.org> on 2017/02/18 13:54:14 UTC
[GitHub] commons-lang pull request #237: (doc) Use the full alphabet for the well-kno...
GitHub user gesellix opened a pull request:
https://github.com/apache/commons-lang/pull/237
(doc) Use the full alphabet for the well-known example text.
This change adds the missing `s` character to complete the `[a-z]` namespace.
Since the commit only affects Javadoc and test code, I refrained from creating a Jira issue. If I should create one, please leave a comment.
I have signed the ICLA via email.
Signed-off-by: Tobias Gesellchen <to...@gesellix.de>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gesellix/commons-lang master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/237.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #237
----
commit 954ade4c1ae2adc0aaac3a1dbe800495c519520c
Author: Tobias Gesellchen <to...@gesellix.de>
Date: 2017-02-18T13:49:42Z
(doc) Use the full alphabet for the well-known example text.
This change adds the missing `s` character.
Signed-off-by: Tobias Gesellchen <to...@gesellix.de>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #237: (doc) Use the full alphabet for the well-kno...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/237
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #237: (doc) Use the full alphabet for the well-known exam...
Posted by chtompki <gi...@git.apache.org>.
Github user chtompki commented on the issue:
https://github.com/apache/commons-lang/pull/237
Wait, I should have read that more completely. I agree with this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #237: (doc) Use the full alphabet for the well-known exam...
Posted by chtompki <gi...@git.apache.org>.
Github user chtompki commented on the issue:
https://github.com/apache/commons-lang/pull/237
I should say. Many thanks for the contribution. Keep up the good work. Cheers, -Rob.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #237: (doc) Use the full alphabet for the well-known exam...
Posted by chtompki <gi...@git.apache.org>.
Github user chtompki commented on the issue:
https://github.com/apache/commons-lang/pull/237
Yes of course. My first read had it moving from "s" to "ed." Clearly a bad read on my part. Doh! :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #237: (doc) Use the full alphabet for the well-known exam...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/237
[](https://coveralls.io/builds/10217218)
Coverage remained the same at 94.53% when pulling **954ade4c1ae2adc0aaac3a1dbe800495c519520c on gesellix:master** into **1661e5519c4836a5a940b13b7797263443156fc9 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #237: (doc) Use the full alphabet for the well-known exam...
Posted by gesellix <gi...@git.apache.org>.
Github user gesellix commented on the issue:
https://github.com/apache/commons-lang/pull/237
You're certainly right that the sentence makes more sense in a context related to font types. Yet, regardless of the context, since that sentence _is_ a standard, we should at least copy it without typos ;-)
Thanks for the quick review + merge!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---