[jira] [Commented] (FLINK-7598) ineffective shaded artifacts checks in travis_mvn_watchdog.sh

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156611#comment-16156611 ] 

ASF GitHub Bot commented on FLINK-7598:
---------------------------------------

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/4653

    [FLINK-7598][travis] fix ineffective shaded artifacts checks

    ## What is the purpose of the change
    
    This fixes the Netty shaded dependencies check and makes all of the checks more robust against failures of the executed commands counting the number of dependencies.
    
    ## Brief change log
    
    * fix `wc -1` call in the netty shaded dependencies check
    * make all checks more robust against such failures by including unsafe variables in quotes
    
    ## Verifying this change
    
    This change is covered by each travis run and it the following does not show up in the logs, the problem is fixed:
    
    ```
    ./tools/travis_mvn_watchdog.sh: line 382: 10052 Terminated              watchdog
    wc: invalid option -- '1'
    Try 'wc --help' for more information.
    ./tools/travis_mvn_watchdog.sh: line 297: [: !=: unary operator expected
    ```
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-7598

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4653.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4653
    
----
commit 3f88f5dba4d4ec3303671d421f03d78fc7f54440
Author: Nico Kruber <ni...@data-artisans.com>
Date:   2017-09-07T07:19:51Z

    [FLINK-7598][travis] fix ineffective shaded artifacts checks
    
    This fixes the netty check and makes all of them more robust against failures of
    the executed commands counting the number of dependencies.

----


> ineffective shaded artifacts checks in travis_mvn_watchdog.sh
> -------------------------------------------------------------
>
>                 Key: FLINK-7598
>                 URL: https://issues.apache.org/jira/browse/FLINK-7598
>             Project: Flink
>          Issue Type: Bug
>          Components: Travis
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>
> The {{check_shaded_artifacts()}} checks have some shortcomings which render them (partially) ineffective:
> * netty checks use {{wc -1}} but should use {{wc -l}}
> * (all) of these checks do not fail if the executed command fails (as can be seen from the netty checks that pass without the line counting being correct)
> In the travis logs, this shows up as
> {code}
> ./tools/travis_mvn_watchdog.sh: line 382: 10052 Terminated              watchdog
> wc: invalid option -- '1'
> Try 'wc --help' for more information.
> ./tools/travis_mvn_watchdog.sh: line 297: [: !=: unary operator expected
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)