[GitHub] [helix] zhangmeng916 commented on a change in pull request #589: Add CloudConfig operations

[GitBox <gi...@apache.org>]

zhangmeng916 commented on a change in pull request #589: Add CloudConfig operations
URL: https://github.com/apache/helix/pull/589#discussion_r347030377
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
 ##########
 @@ -0,0 +1,120 @@
+package org.apache.helix.model;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.helix.HelixProperty;
+import org.apache.helix.ZNRecord;
+
+/**
+ * Cloud configurations
+ */
+public class CloudConfig extends HelixProperty {
+  /**
+   * Configurable characteristics of a cloud.
+   * NOTE: Do NOT use this field name directly, use its corresponding getter/setter in the
+   * CloudConfig.
+   */
+  public enum CloudConfigProperty {
+    CLOUD_ENABLED, // determine whether the cluster is inside cloud environment.
+    CLOUD_ID, // the cloud Id that belongs to this cluster.
+    TOPOLOGY_URL, // the url from where to retrieve the topology information.
+    TOPOLOGY_PARSER, // the name of the function that parses the topology.
 
 Review comment:
   Let's make the two fields starting with "TOPOLOGY" be more generic. The fetcher and parser actually handle more information than just topology. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org