You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/22 19:32:22 UTC
[GitHub] zentol commented on a change in pull request #6899: [FLINK-10637]
Use MiniClusterResource for tests in flink-runtime
zentol commented on a change in pull request #6899: [FLINK-10637] Use MiniClusterResource for tests in flink-runtime
URL: https://github.com/apache/flink/pull/6899#discussion_r227037526
##########
File path: flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/BigUserProgramJobSubmitITCase.java
##########
@@ -122,8 +83,9 @@ public String map(Integer value) throws Exception {
}).addSink(resultSink);
JobGraph jobGraph = StreamingJobGraphGenerator.createJobGraph(env.getStreamGraph());
- CLIENT.setDetached(false);
- CLIENT.submitJob(jobGraph, BigUserProgramJobSubmitITCase.class.getClassLoader());
+ final ClusterClient<?> clusterClient = MINI_CLUSTER_RESOURCE.getClusterClient();
+ clusterClient.setDetached(false);
+ clusterClient.submitJob(jobGraph, BigUserProgramJobSubmitITCase.class.getClassLoader());
Review comment:
You're changing the behavior of this test since it no longer uses a REST client. This should be reverted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services