You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/01/19 13:25:37 UTC

[GitHub] KellenSunderland commented on issue #9472: [Review Required] Adding more file formats to license_header.py (.m, .mk, .R, .cfg)

KellenSunderland commented on issue #9472: [Review Required] Adding more file formats to license_header.py (.m, .mk, .R, .cfg)
URL: https://github.com/apache/incubator-mxnet/pull/9472#issuecomment-358965254
 
 
   @mbaijal The issue that sometimes comes up with large commits is that when you squash two different types of changes together you make it difficult for other devs to merge the commit, and you make it quite hard to revert one of the changes at a later period in time.  Given this I'd recommend splitting the whitespace changes into their own commit and then merging without squashing.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services