You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Jeremy Daggett <no...@github.com> on 2014/10/08 06:14:30 UTC
[jclouds] Support Nova Block Device Mapping v2 Boot (#558)
This PR updates the `BlockDeviceMapping` class used when creating a new server to use the new [v2 format](
http://developer.openstack.org/api-ref-compute-v2-ext.html#ext-os-block-device-mapping-v2-boot).
JIRA: https://issues.apache.org/jira/browse/JCLOUDS-281
You can merge this Pull Request by running:
git pull https://github.com/rackspace/jclouds nova/bfv_v2
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/558
-- Commit Summary --
* JCLOUDS-281: Support Nova Block Device Mapping v2 Boot
-- File Changes --
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/domain/BlockDeviceMapping.java (358)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/ExtensionNamespaces.java (14)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/options/CreateServerOptions.java (232)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/VolumeAttachmentApiLiveTest.java (6)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/features/ServerApiExpectTest.java (43)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/features/ServerApiLiveTest.java (47)
M apis/openstack-nova/src/test/resources/extension_list_full.json (8)
M apis/openstack-nova/src/test/resources/new_server_networks_response.json (2)
M apis/openstack-nova/src/test/resources/new_server_no_adminpass.json (2)
M apis/openstack-nova/src/test/resources/server_details_without_image.json (2)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/558.patch
https://github.com/jclouds/jclouds/pull/558.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/558
Re: [jclouds] Support Nova Block Device Mapping v2 Boot (#558)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1254](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1254/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/558#issuecomment-58311191
Re: [jclouds] Support Nova Block Device Mapping v2 Boot (#558)
Posted by Adrian Cole <no...@github.com>.
+1 after adding a TODO that explains how we will in the future make this not have to be ignored :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/558#issuecomment-58307562
Re: [jclouds] Support Nova Block Device Mapping v2 Boot (#558)
Posted by Jeremy Daggett <no...@github.com>.
Pushed to master 00b2de6 and 1.8.x 8122f0b
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/558#issuecomment-58316256
Re: [jclouds] Support Nova Block Device Mapping v2 Boot (#558)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #165](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/165/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/558#issuecomment-58306561
Re: [jclouds] Support Nova Block Device Mapping v2 Boot (#558)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1747](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1747/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/558#issuecomment-58310378
Re: [jclouds] Support Nova Block Device Mapping v2 Boot (#558)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #167](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/167/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/558#issuecomment-58310642
Re: [jclouds] Support Nova Block Device Mapping v2 Boot (#558)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1256](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1256/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/558#issuecomment-58313751
Re: [jclouds] Support Nova Block Device Mapping v2 Boot (#558)
Posted by Jeremy Daggett <no...@github.com>.
merging shortly
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/558#issuecomment-58310729
Re: [jclouds] Support Nova Block Device Mapping v2 Boot (#558)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1749](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1749/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/558#issuecomment-58317505
Re: [jclouds] Support Nova Block Device Mapping v2 Boot (#558)
Posted by Adrian Cole <no...@github.com>.
> @@ -281,6 +281,14 @@
> "description": "1. Add availability_zone to the Create Server v1.1 API.\n 2. Add availability zones describing.\n "
> },
> {
> + "updated":"2013-07-08T00:00:00+00:00",
> + "name":"BlockDeviceMappingV2Boot",
> + "links":[],
> + "namespace":"http://docs.openstack.org/compute/ext/block_device_mapping_v2_boot/api/v2",
can we not use the extension api in the test?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/558/files#r18563973
Re: [jclouds] Support Nova Block Device Mapping v2 Boot (#558)
Posted by Adrian Cole <no...@github.com>.
> @@ -132,6 +132,45 @@ public void testCreateWithNetworkOptions() {
> }
> }
>
> + /**
> + * This test creates a new server with a boot device from an image.
> + *
> + * This needs to be supported by the provider, and is usually not supported.
> + *
> + * TODO: Configurable system properties for flavor/image refs.
> + */
> + @Test(enabled = false)
> + public void testCreateWithBlockDeviceMapping() {
> + String serverId = null;
I'd prefer to see this guarded with an extensionApi check on the namespace. disabled tests are much more likely to become debt. I understand that the hard-coded ids below might not work even with that in place, so at least put a TODO: guard with extensionApi on os-block-device-mapping-v2-boot or throw SkipException
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/558/files#r18564024