You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/06 21:11:10 UTC
[GitHub] [tvm] gromero opened a new pull request #8941: [microTVM] Zephyr: implement 'west_cmd' server option
gromero opened a new pull request #8941:
URL: https://github.com/apache/tvm/pull/8941
Currently Zephyr Project API server lists option 'west_cmd' as an
option available in Zephyr platform by advertising it in PROJECT_OPTIONS
but that option is not used by any API method.
That commit adds that option to the server as a non-required option to
the flash() interface method, allowing the user to specify an
alternative path to the west tool. If that option is not specified the
Zephyr build system takes care of searching for west as a module (so
relying on West being available on Python, i.e. relying on
'python3 -m west').
Signed-off-by: Gustavo Romero <gu...@linaro.org>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #8941: [microTVM] Zephyr: implement 'west_cmd' server option
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #8941:
URL: https://github.com/apache/tvm/pull/8941#issuecomment-916752046
This is merged now, thanks @gromero and @areusch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron merged pull request #8941: [microTVM] Zephyr: implement 'west_cmd' server option
Posted by GitBox <gi...@apache.org>.
leandron merged pull request #8941:
URL: https://github.com/apache/tvm/pull/8941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on a change in pull request #8941: [microTVM] Zephyr: implement 'west_cmd' server option
Posted by GitBox <gi...@apache.org>.
gromero commented on a change in pull request #8941:
URL: https://github.com/apache/tvm/pull/8941#discussion_r704882645
##########
File path: apps/microtvm/zephyr/template_project/microtvm_api_server.py
##########
@@ -451,6 +451,11 @@ def flash(self, options):
recover_args.extend(_get_nrf_device_args(options))
check_call(recover_args, cwd=API_SERVER_DIR / "build")
+ if "west_cmd" in options:
+ west_cmd = options["west_cmd"]
+ cmake_args = ["cmake", "..", f"-DWEST={west_cmd}"]
Review comment:
@areusch Yeah, I was following what we had previously to Project API. Makes sense. Done in https://github.com/apache/tvm/pull/8941/commits/395bcbe88399adcd0134711ad6da56d6a42297ea
Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #8941: [microTVM] Zephyr: implement 'west_cmd' server option
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #8941:
URL: https://github.com/apache/tvm/pull/8941#discussion_r704712000
##########
File path: apps/microtvm/zephyr/template_project/microtvm_api_server.py
##########
@@ -451,6 +451,11 @@ def flash(self, options):
recover_args.extend(_get_nrf_device_args(options))
check_call(recover_args, cwd=API_SERVER_DIR / "build")
+ if "west_cmd" in options:
+ west_cmd = options["west_cmd"]
+ cmake_args = ["cmake", "..", f"-DWEST={west_cmd}"]
Review comment:
i wonder if we should add this option to the original cmake invocation on line 395? i think it makes sense to have `west_cmd`, but thinking it's better to place there just in case this triggers a rebuild.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on a change in pull request #8941: [microTVM] Zephyr: implement 'west_cmd' server option
Posted by GitBox <gi...@apache.org>.
gromero commented on a change in pull request #8941:
URL: https://github.com/apache/tvm/pull/8941#discussion_r704882645
##########
File path: apps/microtvm/zephyr/template_project/microtvm_api_server.py
##########
@@ -451,6 +451,11 @@ def flash(self, options):
recover_args.extend(_get_nrf_device_args(options))
check_call(recover_args, cwd=API_SERVER_DIR / "build")
+ if "west_cmd" in options:
+ west_cmd = options["west_cmd"]
+ cmake_args = ["cmake", "..", f"-DWEST={west_cmd}"]
Review comment:
@areusch Yeah, I was following what we had prior to Project API. Makes sense. Done in https://github.com/apache/tvm/pull/8941/commits/395bcbe88399adcd0134711ad6da56d6a42297ea
Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org