You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jclouds.apache.org by an...@apache.org on 2016/09/11 23:52:50 UTC
[2/2] jclouds-karaf git commit: Show a more concise evaluation error
in the UI
Show a more concise evaluation error in the UI
More detailed error is logged
Project: http://git-wip-us.apache.org/repos/asf/jclouds-karaf/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds-karaf/commit/6c0c7e6e
Tree: http://git-wip-us.apache.org/repos/asf/jclouds-karaf/tree/6c0c7e6e
Diff: http://git-wip-us.apache.org/repos/asf/jclouds-karaf/diff/6c0c7e6e
Branch: refs/heads/fix-script-engine
Commit: 6c0c7e6e80e82e32a3d77b424c36e7390b5e788c
Parents: 4014f4c
Author: Andrew Phillips <an...@apache.org>
Authored: Mon Sep 12 00:51:11 2016 +0100
Committer: Andrew Phillips <an...@apache.org>
Committed: Mon Sep 12 00:51:11 2016 +0100
----------------------------------------------------------------------
.../commands/table/internal/ScriptEngineShellTable.java | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds-karaf/blob/6c0c7e6e/commands/src/main/java/org/jclouds/karaf/commands/table/internal/ScriptEngineShellTable.java
----------------------------------------------------------------------
diff --git a/commands/src/main/java/org/jclouds/karaf/commands/table/internal/ScriptEngineShellTable.java b/commands/src/main/java/org/jclouds/karaf/commands/table/internal/ScriptEngineShellTable.java
index 5f2733f..e3a3ac9 100644
--- a/commands/src/main/java/org/jclouds/karaf/commands/table/internal/ScriptEngineShellTable.java
+++ b/commands/src/main/java/org/jclouds/karaf/commands/table/internal/ScriptEngineShellTable.java
@@ -17,9 +17,9 @@
package org.jclouds.karaf.commands.table.internal;
-import static java.lang.String.format;
-
import org.jclouds.karaf.commands.table.BasicShellTable;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import javax.script.ScriptEngine;
import javax.script.ScriptEngineManager;
@@ -28,6 +28,8 @@ import javax.script.ScriptEngineManager;
* A shell table implementation that works with groovy expressions.
*/
public class ScriptEngineShellTable<D extends Object> extends BasicShellTable<D> {
+ private static final Logger LOGGER = LoggerFactory.getLogger(ScriptEngineShellTable.class);
+
private final ScriptEngine scriptEngine;
/**
@@ -53,8 +55,9 @@ public class ScriptEngineShellTable<D extends Object> extends BasicShellTable<D>
scriptEngine.put(getType(), obj);
result = String.valueOf(scriptEngine.eval(expression));
} catch (Exception exception) {
- result = format("Unable to evaluate expression %s due to: %s. Please check your shell confugration",
+ LOGGER.warn("Unable to evaluate expression %s due to: %s. Please check your shell confugration",
expression, exception.getMessage());
+ result = "<evalution error - see log>";
}
return result;
}