[jira] [Commented] (AMQ-6108) SelectorManager Executor is not shutdown when transport os stopped.

["Christopher L. Shannon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-6108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083458#comment-15083458 ] 

Christopher L. Shannon commented on AMQ-6108:
---------------------------------------------

It's a good idea to include a test if possible to demonstrate the issue (in this case to show that the shutdown hangs) and also to show that your patch fixes the problem.  It also helps to make sure that any future changes won't cause the problem to show up again.

> SelectorManager Executor is not shutdown when transport os stopped.
> -------------------------------------------------------------------
>
>                 Key: AMQ-6108
>                 URL: https://issues.apache.org/jira/browse/AMQ-6108
>             Project: ActiveMQ
>          Issue Type: Bug
>            Reporter: Andy Gumbrecht
>             Fix For: 5.13.1
>
>         Attachments: SelectorManager.Shutdown.patch
>
>
> SelectorManager creates an Executor that is not shut down on termination of the Transport.
> The Executor currently uses non-daemon threads and is is not guaranteed the the SelectorWorker thread exit condition is ever met.
> This causes the shutdown to hang when using transports that utilise the SelectorManager, such as nio+ssl for example.
> The proposed patch shuts down the ExecutorService on/after Transport shutdown. The SelectorWorkers also check for this as an exit condition.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)