You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "laglangyue (via GitHub)" <gi...@apache.org> on 2023/12/16 09:24:39 UTC

[PR] [jms] Migrate akka dependencies to pekko [incubator-pekko-connectors-samples]

laglangyue opened a new pull request, #14:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/14

   this pr inclueds:
   Using pekko instead of akka in document and code dependencies
   Test:
   test local by  `docker 24.0.7 on Mint Linux 21`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] [jms] Migrate akka dependencies to pekko [incubator-pekko-connectors-samples]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #14:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/14


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] [jms] Migrate akka dependencies to pekko [incubator-pekko-connectors-samples]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #14:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/14#discussion_r1428754907


##########
pekko-connectors-sample-jms/project/Dependencies.scala:
##########
@@ -1,25 +1,26 @@
 import sbt._
 
 object Dependencies {
-  val scalaVer = "2.13.7"
+  val scalaVer = "2.13.12"
   // #deps
-  val AkkaVersion = "2.6.19"
-  val AkkaHttpVersion = "10.1.12"
-  val AlpakkaVersion = "4.0.0"
+  val pekkoVersion = "1.0.1"
+  val pekkoHttpVersion = "1.0.0"
+  // todo: move to "1.0.2" after release in maven
+  val pekkoConnectorVersion = "1.0.1-RC1+6-dcc040bb-SNAPSHOT"

Review Comment:
   pekkoConnectorVersion=1.0.1 is released - please do not use snapshot versions
   
   also use `pekkoVersion = "1.0.2"`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] [jms] Migrate akka dependencies to pekko [incubator-pekko-connectors-samples]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #14:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/14#discussion_r1428754907


##########
pekko-connectors-sample-jms/project/Dependencies.scala:
##########
@@ -1,25 +1,26 @@
 import sbt._
 
 object Dependencies {
-  val scalaVer = "2.13.7"
+  val scalaVer = "2.13.12"
   // #deps
-  val AkkaVersion = "2.6.19"
-  val AkkaHttpVersion = "10.1.12"
-  val AlpakkaVersion = "4.0.0"
+  val pekkoVersion = "1.0.1"
+  val pekkoHttpVersion = "1.0.0"
+  // todo: move to "1.0.2" after release in maven
+  val pekkoConnectorVersion = "1.0.1-RC1+6-dcc040bb-SNAPSHOT"

Review Comment:
   pekkoConnectorVersion=1.0.2 is released - please do not use snapshot versions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] [jms] Migrate akka dependencies to pekko [incubator-pekko-connectors-samples]

Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on code in PR #14:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/14#discussion_r1428768168


##########
pekko-connectors-sample-jms/project/Dependencies.scala:
##########
@@ -1,25 +1,26 @@
 import sbt._
 
 object Dependencies {
-  val scalaVer = "2.13.7"
+  val scalaVer = "2.13.12"
   // #deps
-  val AkkaVersion = "2.6.19"
-  val AkkaHttpVersion = "10.1.12"
-  val AlpakkaVersion = "4.0.0"
+  val pekkoVersion = "1.0.1"
+  val pekkoHttpVersion = "1.0.0"
+  // todo: move to "1.0.2" after release in maven
+  val pekkoConnectorVersion = "1.0.1-RC1+6-dcc040bb-SNAPSHOT"

Review Comment:
   for JMS,there is released 1.0.1 in maven center(https://mvnrepository.com/artifact/org.apache.pekko/pekko-connectors-jms)
   
   I will change it soon.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org