Re: [PR] feat: remove native cast from boolean to decimal [datafusion-comet]

["andygrove (via GitHub)" <gi...@apache.org>]

andygrove commented on code in PR #5185:
URL: https://github.com/apache/datafusion-comet/pull/5185#discussion_r3708490627


##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -177,10 +177,25 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
     castTest(generateBools(), DataTypes.DoubleType)
   }
 
-  test("cast BooleanType to DecimalType(10,2)") {
+  // Boolean -> Decimal has no native path and is routed through the JVM codegen dispatcher, so
+  // `CometCast.isSupported` reports it as unsupported and the matrix-consistency test above
+  // requires this one to be ignored. Execution coverage, including the ANSI overflow edge cases,
+  // lives in `sql-tests/expressions/cast/cast_boolean_to_decimal{,_ansi}.sql`.
+  ignore("cast BooleanType to DecimalType(10,2)") {

Review Comment:
   CometCastSuite was implemented before we added support for codegen fallback. If we unignore the test, the suite fails because the expr is marked as unsupported. We'll need to improve this suite now that we have codgen dispatch fallback.  I filed https://github.com/apache/datafusion-comet/issues/5186



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org