You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/22 12:40:18 UTC

[GitHub] [dolphinscheduler] Amy0104 commented on a change in pull request #9102: [Fix][UI Next][V1.0.0-Alpha] Fix the task icons not shown in dag page.

Amy0104 commented on a change in pull request #9102:
URL: https://github.com/apache/dolphinscheduler/pull/9102#discussion_r832125230



##########
File path: dolphinscheduler-ui-next/src/views/projects/workflow/components/dag/use-cell-active.ts
##########
@@ -89,29 +86,17 @@ export function useCellActive(options: Options) {
       PORT_SELECTED.groups[X6_PORT_OUT_NAME].attrs
     )
     const portDefault = _.cloneDeep(PORT.groups[X6_PORT_OUT_NAME].attrs)
-    const nodeHover = _.merge(_.cloneDeep(NODE.attrs), NODE_HOVER.attrs)
-    const nodeSelected = _.merge(_.cloneDeep(NODE.attrs), NODE_SELECTED.attrs)
 
-    let img = null
-    let nodeAttrs = null
     let portAttrs = null
-
     if (isHover || isSelected) {

Review comment:
       It has be handled in the style.
   <img width="548" alt="image" src="https://user-images.githubusercontent.com/97265214/159484007-d2bc65ea-2530-4b25-ab29-6e870943a3b8.png">




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org