You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/09/27 19:47:35 UTC
[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request, #1378: nimble/ll: Fix MIC failure during encryption start
andrzej-kaczmarek opened a new pull request, #1378:
URL: https://github.com/apache/mynewt-nimble/pull/1378
This fixes unexpected MIC failure when retransmission happens during encryption start procedure as follows:
- peripheral sends LL_START_ENC_REQ unencrypted, central acks
- central sends LL_START_ENC_RSP encrypted, peripheral acks
- central retransmits LL_START_ENC_RSP for whatever reason
The problem is that peripheral increments rx packet counter after 1st LL_START_ENC_RSP is received, so retransmission is decrypted with different rx packet counter and thus is not valid. We properly ignore MIC failure for retransmission, but then code checks if received PDU is valid in currect state, i.e. encryption start procedure. Since it was not properly decrypted, the PDU type is likely garbage and thus considered as not allowed so we terminate connection with MIC failure.
The "ultimate" fix for such issues is to simply ignore any retransmitted PDU with MIC failure since basically contents of such PDUs are garbage and not really useful for any checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] jrotkiewicz commented on pull request #1378: nimble/ll: Fix MIC failure during encryption start
Posted by GitBox <gi...@apache.org>.
jrotkiewicz commented on PR #1378:
URL: https://github.com/apache/mynewt-nimble/pull/1378#issuecomment-1260737965
Tested few hundred of times and I could not reproduce mic failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1378: nimble/ll: Fix MIC failure during encryption start
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1378:
URL: https://github.com/apache/mynewt-nimble/pull/1378#issuecomment-1259977332
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1378: nimble/ll: Fix MIC failure during encryption start
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek merged PR #1378:
URL: https://github.com/apache/mynewt-nimble/pull/1378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org