You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/02 20:56:37 UTC

[GitHub] [incubator-superset] john-bodley opened a new pull request #9970: style(mypy): Fix memoize watch type

john-bodley opened a new pull request #9970:
URL: https://github.com/apache/incubator-superset/pull/9970


   ### SUMMARY
   
   The `watch` variable type was incorrectly encoded as as I wasn't aware of (or forgot) the `...` syntax for defining a tuple of arbitrary length, i.e., `Tuple[str, ...]`.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   
   CI.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9970: style(mypy): Fix memoize watch type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9970:
URL: https://github.com/apache/incubator-superset/pull/9970#issuecomment-637805233


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=h1) Report
   > Merging [#9970](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc92692f491f6179d99118aeb7325977ce53cb59&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9970/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9970      +/-   ##
   ==========================================
   + Coverage   71.34%   71.36%   +0.01%     
   ==========================================
     Files         585      585              
     Lines       30914    30914              
     Branches     3246     3246              
   ==========================================
   + Hits        22057    22061       +4     
   + Misses       8747     8744       -3     
   + Partials      110      109       -1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `54.00% <ø> (+0.03%)` | :arrow_up: |
   | #javascript | `59.39% <ø> (ø)` | |
   | #python | `71.54% <100.00%> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.29% <100.00%> (ø)` | |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.18% <100.00%> (ø)` | |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `66.81% <0.00%> (+0.65%)` | :arrow_up: |
   | [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `89.88% <0.00%> (+1.12%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=footer). Last update [fc92692...b462b25](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] john-bodley commented on pull request #9970: style(mypy): Fix memoize watch type

Posted by GitBox <gi...@apache.org>.
john-bodley commented on pull request #9970:
URL: https://github.com/apache/incubator-superset/pull/9970#issuecomment-637815161


   @villebro it was working correctly. The reason for the change was to adhere to the original intent where the author used a `tuple` rather than a `list`. That's a whole other discussion as I sense in Superset (and other Python repos) many objects which could/should be tuples are defined as lists.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter commented on pull request #9970: style(mypy): Fix memoize watch type

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9970:
URL: https://github.com/apache/incubator-superset/pull/9970#issuecomment-637805233


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=h1) Report
   > Merging [#9970](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc92692f491f6179d99118aeb7325977ce53cb59&el=desc) will **decrease** coverage by `11.95%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9970/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9970       +/-   ##
   ===========================================
   - Coverage   71.34%   59.39%   -11.96%     
   ===========================================
     Files         585      401      -184     
     Lines       30914    12762    -18152     
     Branches     3246     3246               
   ===========================================
   - Hits        22057     7580    -14477     
   + Misses       8747     5003     -3744     
   - Partials      110      179       +69     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.39% <ø> (ø)` | |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [319 more](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=footer). Last update [fc92692...b462b25](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9970: style(mypy): Fix memoize watch type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9970:
URL: https://github.com/apache/incubator-superset/pull/9970#issuecomment-637805233


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=h1) Report
   > Merging [#9970](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc92692f491f6179d99118aeb7325977ce53cb59&el=desc) will **decrease** coverage by `0.32%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9970/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9970      +/-   ##
   ==========================================
   - Coverage   71.34%   71.02%   -0.33%     
   ==========================================
     Files         585      585              
     Lines       30914    30800     -114     
     Branches     3246     3246              
   ==========================================
   - Hits        22057    21875     -182     
   - Misses       8747     8810      +63     
   - Partials      110      115       +5     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.22% <ø> (-0.75%)` | :arrow_down: |
   | #javascript | `59.39% <ø> (ø)` | |
   | #python | `71.29% <100.00%> (-0.25%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.42% <100.00%> (-0.88%)` | :arrow_down: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.18% <100.00%> (ø)` | |
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `63.33% <0.00%> (-10.01%)` | :arrow_down: |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `76.22% <0.00%> (-5.60%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.03%)` | :arrow_down: |
   | [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
   | ... and [22 more](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=footer). Last update [fc92692...b462b25](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] john-bodley merged pull request #9970: style(mypy): Fix memoize watch type

Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #9970:
URL: https://github.com/apache/incubator-superset/pull/9970


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9970: style(mypy): Fix memoize watch type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9970:
URL: https://github.com/apache/incubator-superset/pull/9970#issuecomment-637805233


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=h1) Report
   > Merging [#9970](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc92692f491f6179d99118aeb7325977ce53cb59&el=desc) will **decrease** coverage by `0.06%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9970/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9970      +/-   ##
   ==========================================
   - Coverage   71.34%   71.28%   -0.07%     
   ==========================================
     Files         585      585              
     Lines       30914    30800     -114     
     Branches     3246     3246              
   ==========================================
   - Hits        22057    21955     -102     
   + Misses       8747     8736      -11     
   + Partials      110      109       -1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `54.00% <ø> (+0.03%)` | :arrow_up: |
   | #javascript | `59.39% <ø> (ø)` | |
   | #python | `71.40% <100.00%> (-0.14%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.29% <100.00%> (ø)` | |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.18% <100.00%> (ø)` | |
   | [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
   | [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `59.06% <0.00%> (-3.29%)` | :arrow_down: |
   | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.72% <0.00%> (-3.14%)` | :arrow_down: |
   | [superset/views/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYXBpLnB5) | `63.63% <0.00%> (-2.08%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.70% <0.00%> (-0.88%)` | :arrow_down: |
   | [superset/views/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `60.55% <0.00%> (-0.36%)` | :arrow_down: |
   | [superset/extensions.py](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `95.06% <0.00%> (-0.29%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.12% <0.00%> (-0.24%)` | :arrow_down: |
   | ... and [9 more](https://codecov.io/gh/apache/incubator-superset/pull/9970/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=footer). Last update [fc92692...b462b25](https://codecov.io/gh/apache/incubator-superset/pull/9970?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org