You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/11/16 03:28:19 UTC
[GitHub] [shardingsphere] cheese8 opened a new issue #13634: [Disscussion] Why we need an optional parse skiped phase in encrypt scenarioes.
cheese8 opened a new issue #13634:
URL: https://github.com/apache/shardingsphere/issues/13634
## The purpose:
1、Enhance users' confidence in using SS.
2、Reduce test coverage and workload in using SS.
## Scenarios:
Encrypt only.
Why an optional parse skipped parse could enhance user confidence?
1、Encrypt and decrypt are generally compliance requirements, and when your system needs compliance, which means it is already large and the situation is complicated, for example, no unit test or unit test is not enough etc. Do you agree with this?
2、Then are there a lot of SQLs, and there are some SQLs containing encrypt tables/fields, others not at all. It is the reality.
3、The first solution is developers manually modify the SQLs which containing encrypt tables/fields one by one, it is the most simple, direct and easiest to accept solution, as the scope that needs to be developed and tested is fixed. Do you agree with this?
4、The SS's encrypt solution is almost perfect, but:
> all SQLs should be parsed and some SQLs are not parsed well.
> all SQLs need to be parsed, which cause the unacceptable by test.
If SS says that only the SQLs which containing encrypt tables/fields is parsed and rewritten, the other SQLs parse phase can be skipped.
Do you agree with this? Look forward to your opinions @strongduanmu @tristaZero @terrymanu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #13634: [Disscussion] Why we need an optional parse skiped phase in encrypt scenarioes.
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #13634:
URL: https://github.com/apache/shardingsphere/issues/13634#issuecomment-969854997
@cheese8 Parsing is necessary for now. Only after parsing, we can extract the table segment in the statement and then determine whether we need to rewrite it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] cheese8 commented on issue #13634: [Disscussion] Why we need an optional parse skiped phase in encrypt scenarioes.
Posted by GitBox <gi...@apache.org>.
cheese8 commented on issue #13634:
URL: https://github.com/apache/shardingsphere/issues/13634#issuecomment-972483104
@strongduanmu ye, i know this by reading the source code, and I think the most important thing is the risk problems that all SQL will be parsed which the test can not cover it completely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed issue #13634: [Disscussion] Why we need an optional parse skiped phase in encrypt scenarioes.
Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #13634:
URL: https://github.com/apache/shardingsphere/issues/13634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #13634: [Disscussion] Why we need an optional parse skiped phase in encrypt scenarioes.
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #13634:
URL: https://github.com/apache/shardingsphere/issues/13634#issuecomment-997432348
Just as @strongduanmu said, SQL parser is the necessary step.
We can enhance the SQL parser if there are some bugs, but cannot accept to skip SQL parser which will break the basic concept of ShardingSphere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org